chrome/android/webapk/shell_apk/shell_apk_version.gni - Issue 2860193002: Correctly record WebAPK install source for Launch.HomescreenSource

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/webapk/shell_apk/shell_apk_version.gni

Issue 2860193002: Correctly record WebAPK install source for Launch.HomescreenSource (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/android/webapk/shell_apk/shell_apk_version.gni

diff --git a/chrome/android/webapk/shell_apk/shell_apk_version.gni b/chrome/android/webapk/shell_apk/shell_apk_version.gni

index c4d66ff1992df3516f9c88b69d6db437168908f1..2ca4a930fa1d386a9b8db529459f2e76b8e9b427 100644

--- a/chrome/android/webapk/shell_apk/shell_apk_version.gni

+++ b/chrome/android/webapk/shell_apk/shell_apk_version.gni

@@ -6,7 +6,7 @@

# (including AndroidManifest.xml) is updated. This version should be incremented

# prior to uploading a new ShellAPK to the WebAPK Minting Server.

# Does not affect Chrome.apk

-template_shell_apk_version = 4

+template_shell_apk_version = 5

pkotwicz 2017/05/05 21:05:43 6 because of https://codereview.chromium.org/28498

Xi Han 2017/05/08 20:55:28 I will rebase after this CL lands:)

# The ShellAPK version expected by Chrome. Chrome will try to update the WebAPK

# if the WebAPK's ShellAPK version is less than |expected_shell_apk_version|.