chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java - Issue 2860193002: Correctly record WebAPK install source for Launch.HomescreenSource

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java

Issue 2860193002: Correctly record WebAPK install source for Launch.HomescreenSource (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/webapk/shell_apk/shell_apk_version.gni ('K') | « chrome/android/webapk/shell_apk/shell_apk_version.gni ('k') | chrome/browser/android/shortcut_info.h » ('j') | chrome/browser/android/shortcut_info.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java

diff --git a/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java b/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java

index e30875d3a331c1bbdfff0a3290f591ff735ed751..c1051ba223c46ab390e7d8d7b7c10a455ba69fc9 100644

--- a/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java

+++ b/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java

@@ -93,8 +93,9 @@ public class MainActivity extends Activity {

String runtimeHost = WebApkUtils.getHostBrowserPackageName(this);

boolean isFromExternalIntent = (overrideUrl != null);

- int source = getIntent().getIntExtra(WebApkConstants.EXTRA_SOURCE, 0);

- if (isFromExternalIntent && source == WebApkConstants.SHORTCUT_SOURCE_UNKNOWN) {

+ int source = getIntent().getIntExtra(

+ WebApkConstants.EXTRA_SOURCE, WebApkConstants.SHORTCUT_SOURCE_WEBAPK_UNKNOWN);

+ if (isFromExternalIntent && source == WebApkConstants.SHORTCUT_SOURCE_WEBAPK_UNKNOWN) {

source = WebApkConstants.SHORTCUT_SOURCE_EXTERNAL_INTENT;

}