[Mac] Fix for Tab Fullscreen Touch Bar

[Mac] Fix for Tab Fullscreen Touch Bar

The touch bar for tab fullscreen should get its own
identifier. Otherwise, editing the default browser touch
bar will have an effect on it.

BUG=690611
Review-Url: https://codereview.chromium.org/2860163004
Cr-Commit-Position: refs/heads/master@{#469801}
Committed: https://chromium.googlesource.com/chromium/src/+/e01a3a5f99941448100d68e92c76f5ae172595ee

[spqchan, 2017-05-04 23:44:31]

The CQ bit was checked by spqchan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 23:45:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[spqchan, 2017-05-04 23:49:44]

The CQ bit was checked by spqchan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 23:50:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[spqchan, 2017-05-04 23:55:26]

Description was changed from

==========
[Mac] Fix for Tab Fullscreen Touch Bar

BUG=690611
==========

to

==========
[Mac] Fix for Tab Fullscreen Touch Bar

The touch bar for tab fullscreen should get its own
identifier. Otherwise, editing the default browser touch
bar will have an effect on it.

BUG=690611
==========

[spqchan, 2017-05-04 23:55:26]

spqchan@chromium.org changed reviewers:
+ avi@chromium.org

[commit-bot: I haz the power, 2017-05-05 00:27:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 00:27:34]

Dry run: This issue passed the CQ dry run.

[spqchan, 2017-05-05 17:56:53]

PTAL

[Avi (use Gerrit), 2017-05-05 19:09:34]

lgtm

In general, though, there are a lot of raw constants in the test that make me
wonder if we can reuse declared constants.

https://codereview.chromium.org/2860163004/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/browser_window_touch_bar_unittest.mm (right):

https://codereview.chromium.org/2860163004/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/browser_window_touch_bar_unittest.mm:48: return
[BrowserWindowTouchBar identifierForTouchBarId:@"browser-window"
:( Can't we reuse the constants that you declared?

[spqchan, 2017-05-05 22:22:24]

Patchset #3 (id:40001) has been deleted

[spqchan, 2017-05-05 22:38:09]

thanks!

https://codereview.chromium.org/2860163004/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/browser_window_touch_bar_unittest.mm (right):

https://codereview.chromium.org/2860163004/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/browser_window_touch_bar_unittest.mm:48: return
[BrowserWindowTouchBar identifierForTouchBarId:@"browser-window"
On 2017/05/05 19:09:34, Avi (ping after 24h) wrote:
> :( Can't we reuse the constants that you declared?

Done.

[spqchan, 2017-05-05 22:38:14]

The CQ bit was checked by spqchan@chromium.org

[spqchan, 2017-05-05 22:38:14]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org
Link to the patchset: https://codereview.chromium.org/2860163004/#ps60001
(title: "Fix for avi")

[commit-bot: I haz the power, 2017-05-05 22:39:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 23:36:53]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1494023894109230,
"parent_rev": "b24d2336dc516900281fc2034adaddc29769e3a5", "commit_rev":
"e01a3a5f99941448100d68e92c76f5ae172595ee"}

[commit-bot: I haz the power, 2017-05-05 23:37:43]

Description was changed from

==========
[Mac] Fix for Tab Fullscreen Touch Bar

The touch bar for tab fullscreen should get its own
identifier. Otherwise, editing the default browser touch
bar will have an effect on it.

BUG=690611
==========

to

==========
[Mac] Fix for Tab Fullscreen Touch Bar

The touch bar for tab fullscreen should get its own
identifier. Otherwise, editing the default browser touch
bar will have an effect on it.

BUG=690611

Review-Url: https://codereview.chromium.org/2860163004
Cr-Commit-Position: refs/heads/master@{#469801}
Committed:
https://chromium.googlesource.com/chromium/src/+/e01a3a5f99941448100d68e92c76...
==========

[commit-bot: I haz the power, 2017-05-05 23:37:44]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/e01a3a5f99941448100d68e92c76...