Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2860163004: [Mac] Fix for Tab Fullscreen Touch Bar (Closed)

Created:
3 years, 7 months ago by spqchan
Modified:
3 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Fix for Tab Fullscreen Touch Bar The touch bar for tab fullscreen should get its own identifier. Otherwise, editing the default browser touch bar will have an effect on it. BUG=690611 Review-Url: https://codereview.chromium.org/2860163004 Cr-Commit-Position: refs/heads/master@{#469801} Committed: https://chromium.googlesource.com/chromium/src/+/e01a3a5f99941448100d68e92c76f5ae172595ee

Patch Set 1 #

Patch Set 2 : Nits #

Total comments: 2

Patch Set 3 : Fix for avi #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -52 lines) Patch
M chrome/browser/ui/cocoa/browser_window_touch_bar.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_touch_bar.mm View 1 7 chunks +43 lines, -25 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_touch_bar_unittest.mm View 1 2 5 chunks +50 lines, -25 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
spqchan
PTAL
3 years, 7 months ago (2017-05-05 17:56:53 UTC) #9
Avi (use Gerrit)
lgtm In general, though, there are a lot of raw constants in the test that ...
3 years, 7 months ago (2017-05-05 19:09:34 UTC) #10
spqchan
thanks! https://codereview.chromium.org/2860163004/diff/20001/chrome/browser/ui/cocoa/browser_window_touch_bar_unittest.mm File chrome/browser/ui/cocoa/browser_window_touch_bar_unittest.mm (right): https://codereview.chromium.org/2860163004/diff/20001/chrome/browser/ui/cocoa/browser_window_touch_bar_unittest.mm#newcode48 chrome/browser/ui/cocoa/browser_window_touch_bar_unittest.mm:48: return [BrowserWindowTouchBar identifierForTouchBarId:@"browser-window" On 2017/05/05 19:09:34, Avi (ping ...
3 years, 7 months ago (2017-05-05 22:38:09 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860163004/60001
3 years, 7 months ago (2017-05-05 22:39:09 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 23:37:44 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/e01a3a5f99941448100d68e92c76...

Powered by Google App Engine
This is Rietveld 408576698