Avoid triggering an assert

Avoid triggering an assert

Child::operator= has an assert that it does not overwrite a non-null
pointer.  Avoid triggering the assert by casting to another type.

BUG=
R=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/92cc26eb7a466be183a3850255457b42f8d0f897

[Kevin Millikin (Google), 2017-05-04 20:32:12]

kmillikin@google.com changed reviewers:
+ rmacnak@google.com, zra@google.com

[zra, 2017-05-04 20:51:09]

https://codereview.chromium.org/2860163003/diff/1/runtime/vm/kernel_reader.cc
File runtime/vm/kernel_reader.cc (right):

https://codereview.chromium.org/2860163003/diff/1/runtime/vm/kernel_reader.cc...
runtime/vm/kernel_reader.cc:218: delete procedure->function()->body();
To avoid the hack in set_body, maybe replace these two lines with something
like:

procedure->function()->ReplaceBody(new ReturnStatement(new
StaticGet(NameIndex())));

Maybe you'll still need a hack in ReplaceBody, but it might be better to keep
the hack away from an innocuous-looking setter.

[zra, 2017-05-04 21:28:49]

lgtm

[Kevin Millikin (Google), 2017-05-04 21:29:10]

Thanks for the suggestion.  Please take another look.

[Kevin Millikin (Google), 2017-05-04 21:29:43]

Description was changed from

==========
Avoid triggering an assert

Child::operator= has an assert that it does not overwrite a non-null
pointer.  Avoid triggering the assert by casting to another type.

BUG=
==========

to

==========
Avoid triggering an assert

Child::operator= has an assert that it does not overwrite a non-null
pointer.  Avoid triggering the assert by casting to another type.

BUG=
R=zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/92cc26eb7a466be183a3850255457b42f8d0f897
==========

[Kevin Millikin (Google), 2017-05-04 21:29:47]

Committed patchset #2 (id:20001) manually as
92cc26eb7a466be183a3850255457b42f8d0f897 (presubmit successful).