Avoid triggering an assert

runtime/vm/kernel_reader.cc

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/kernel_reader.h"
 
 #include <string.h>
 
 #include "vm/dart_api_impl.h"
 #include "vm/kernel_binary.h"
@@ skipping 195 matching lines @@
           Z, builtin_library.LookupFunctionAllowPrivate(
                  dart::String::Handle(dart::String::New("_getMainClosure"))));
 
       Procedure* procedure =
           reinterpret_cast<Procedure*>(to_patch.kernel_function());
       // If dart:_builtin was not compiled from Kernel at all it does not need
       // to be patched.
       if (procedure != NULL) {
         // We will handle the StaticGet specially and will not use the name.
         //
-        // TODO(kmillikin): we are leaking the function body.  Find a way to
+        // TODO(kmillikin): we are leaking the new function body.  Find a way to
         // deallocate it.
+        delete procedure->function()->body();

[zra, 2017/05/04 20:51:09]

To avoid the hack in set_body, maybe replace these two lines with something
like:

procedure->function()->ReplaceBody(new ReturnStatement(new
StaticGet(NameIndex())));

Maybe you'll still need a hack in ReplaceBody, but it might be better to keep
the hack away from an innocuous-looking setter.

         procedure->function()->set_body(
             new ReturnStatement(new StaticGet(NameIndex())));
       }
       return library;
     }
   }
 
   // Either class finalization failed or we caught a compile error.
   // In both cases sticky error would be set.
   Error& error = Error::Handle(Z);
@@ skipping 712 matching lines @@
   initializer_fun.set_is_debuggable(false);
   initializer_fun.set_is_reflectable(false);
   initializer_fun.set_is_inlinable(false);
   return new (zone) ParsedFunction(thread, initializer_fun);
 }
 
 
 }  // namespace kernel
 }  // namespace dart
 #endif  // !defined(DART_PRECOMPILED_RUNTIME)