Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2860123002: Revert of [js] Avoid %_ClassOf for collection builtins. (Closed)

Created:
3 years, 7 months ago by Benedikt Meurer
Modified:
3 years, 7 months ago
Reviewers:
Jarin, adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [js] Avoid %_ClassOf for collection builtins. (patchset #4 id:60001 of https://codereview.chromium.org/2814773005/ ) Reason for revert: Breaks node.js integration bot: https://build.chromium.org/p/client.v8.fyi/builders/V8%20-%20node.js%20integration/builds/5374/steps/build%20addons%20and%20test%20node.js/logs/stdio Original issue's description: > [js] Avoid %_ClassOf for collection builtins. > > The collection builtins (Map, Set, WeakMap, WeakSet) are still written > in JavaScript and make heavy use of %_ClassOf, which is kind of > expensive compared to a simple instance type check. Change that to use > simple instance type checks instead. > > R=jarin@chromium.org > BUG=v8:6261, v8:6278, v8:6344 > > Review-Url: https://codereview.chromium.org/2814773005 > Cr-Commit-Position: refs/heads/master@{#45106} > Committed: https://chromium.googlesource.com/v8/v8/+/28170099fd1efc84a724ef133f335fec521c0852 TBR=jarin@chromium.org,adamk@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:6261, v8:6278, v8:6344 Review-Url: https://codereview.chromium.org/2860123002 Cr-Commit-Position: refs/heads/master@{#45108} Committed: https://chromium.googlesource.com/v8/v8/+/ae5ae1cceedcc11b84d7fac1d9937bbf14cd3533

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -91 lines) Patch
M src/compiler/js-intrinsic-lowering.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M src/compiler/linkage.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/debug/debug-evaluate.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/js/macros.py View 1 chunk +8 lines, -7 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -7 lines 0 comments Download
M src/runtime/runtime-collections.cc View 1 chunk +0 lines, -43 lines 0 comments Download
M test/inspector/inspector.status View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Benedikt Meurer
Created Revert of [js] Avoid %_ClassOf for collection builtins.
3 years, 7 months ago (2017-05-04 18:43:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860123002/1
3 years, 7 months ago (2017-05-04 18:43:33 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 18:43:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/ae5ae1cceedcc11b84d7fac1d9937bbf14c...

Powered by Google App Engine
This is Rietveld 408576698