third_party/WebKit/LayoutTests/http/tests/misc/client-hints-accept.php - Issue 2860093003: Implement device-ram client hints header

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/misc/client-hints-accept.php

Issue 2860093003: Implement device-ram client hints header (Closed)

Patch Set: Fix FrameFetchContextTest Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/misc/client-hint-accept-on-subresource.html ('k') | third_party/WebKit/LayoutTests/http/tests/misc/client-hints-accept-meta.html » ('j') | third_party/WebKit/Source/core/frame/UseCounter.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/misc/client-hints-accept.php

diff --git a/third_party/WebKit/LayoutTests/http/tests/misc/client-hints-accept.php b/third_party/WebKit/LayoutTests/http/tests/misc/client-hints-accept.php

index 72f78b09b45224b02d7bbaca669823511d8703bb..2e3ed610c8e51be62cbe984df7041e908d09dbdf 100644

--- a/third_party/WebKit/LayoutTests/http/tests/misc/client-hints-accept.php

+++ b/third_party/WebKit/LayoutTests/http/tests/misc/client-hints-accept.php

@@ -1,5 +1,5 @@

<?php

- header("ACCEPT-CH: DPR, Width, Viewport-Width");

+ header("ACCEPT-CH: DPR, Width, Viewport-Width, Device-Ram");

Yoav Weiss 2017/05/24 07:48:02 Nit: Maybe "Device-RAM"? (I don't think it makes a

fmeawad 2017/05/24 18:24:56 Done.

<!DOCTYPE html>

@@ -11,11 +11,18 @@

assert_unreached("Image should have loaded.");

};

+ var loadDeviceRamImage = function() {

+ var img = new Image();

+ img.src = 'resources/image-checks-for-device-ram.php';

+ img.onload = t.step_func(function(){ t.done(); });

+ img.onerror = t.step_func(unreached);

+ document.body.appendChild(img);

+ };

var loadRWImage = function() {

var img = new Image();

img.src = 'resources/image-checks-for-width.php';

img.sizes = '500';

- img.onload = t.step_func(function(){ t.done(); });

+ img.onload = t.step_func(loadDeviceRamImage);

img.onerror = t.step_func(unreached);

document.body.appendChild(img);

};