third_party/WebKit/LayoutTests/http/tests/misc/client-hints-accept.php - Issue 2860093003: Implement device-ram client hints header

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/misc/client-hints-accept.php

Issue 2860093003: Implement device-ram client hints header (Closed)

Patch Set: Fix FrameFetchContextTest Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/misc/client-hint-accept-on-subresource.html ('k') | third_party/WebKit/LayoutTests/http/tests/misc/client-hints-accept-meta.html » ('j') | third_party/WebKit/Source/core/frame/UseCounter.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?php	1 <?php

2 header("ACCEPT-CH: DPR, Width, Viewport-Width");	2 header("ACCEPT-CH: DPR, Width, Viewport-Width, Device-Ram");
	Yoav Weiss 2017/05/24 07:48:02 Nit: Maybe "Device-RAM"? (I don't think it makes a Nit: Maybe "Device-RAM"? (I don't think it makes any actual difference, but "Ram" makes me think https://qph.ec.quoracdn.net/main-qimg-fe73b568eee0e7ebcaca8f13a9957062-c :D) Similar nit to other places with "Ram" in them. fmeawad 2017/05/24 18:24:56 Done. Show quoted text On 2017/05/24 07:48:02, Yoav Weiss wrote: > Nit: Maybe "Device-RAM"? (I don't think it makes any actual difference, but > "Ram" makes me think > https://qph.ec.quoracdn.net/main-qimg-fe73b568eee0e7ebcaca8f13a9957062-c :D) > > Similar nit to other places with "Ram" in them. Done.
3 ?>	3 ?>

4 <!DOCTYPE html>	4 <!DOCTYPE html>

5 <script src="../resources/testharness.js"></script>	5 <script src="../resources/testharness.js"></script>

6 <script src="../resources/testharnessreport.js"></script>	6 <script src="../resources/testharnessreport.js"></script>

7 <body>	7 <body>

8 <script>	8 <script>

9 var t = async_test('Client-Hints sent when Accept-CH header is present') ;	9 var t = async_test('Client-Hints sent when Accept-CH header is present') ;

10 var unreached = function() {	10 var unreached = function() {

11 assert_unreached("Image should have loaded.");	11 assert_unreached("Image should have loaded.");

12 };	12 };

13	13

	14 var loadDeviceRamImage = function() {

	15 var img = new Image();

	16 img.src = 'resources/image-checks-for-device-ram.php';

	17 img.onload = t.step_func(function(){ t.done(); });

	18 img.onerror = t.step_func(unreached);

	19 document.body.appendChild(img);

	20 };

14 var loadRWImage = function() {	21 var loadRWImage = function() {

15 var img = new Image();	22 var img = new Image();

16 img.src = 'resources/image-checks-for-width.php';	23 img.src = 'resources/image-checks-for-width.php';

17 img.sizes = '500';	24 img.sizes = '500';

18 img.onload = t.step_func(function(){ t.done(); });	25 img.onload = t.step_func(loadDeviceRamImage);

19 img.onerror = t.step_func(unreached);	26 img.onerror = t.step_func(unreached);

20 document.body.appendChild(img);	27 document.body.appendChild(img);

21 };	28 };

22 var loadViewportImage = function() {	29 var loadViewportImage = function() {

23 var img = new Image();	30 var img = new Image();

24 img.src = 'resources/image-checks-for-viewport-width.php';	31 img.src = 'resources/image-checks-for-viewport-width.php';

25 img.onload = t.step_func(loadRWImage);	32 img.onload = t.step_func(loadRWImage);

26 img.onerror = t.step_func(unreached);	33 img.onerror = t.step_func(unreached);

27 document.body.appendChild(img);	34 document.body.appendChild(img);

28 };	35 };

29 t.step(function() {	36 t.step(function() {

30 var img = new Image();	37 var img = new Image();

31 img.src = 'resources/image-checks-for-dpr.php';	38 img.src = 'resources/image-checks-for-dpr.php';

32 img.onload = t.step_func(loadViewportImage);	39 img.onload = t.step_func(loadViewportImage);

33 img.onerror = t.step_func(unreached);	40 img.onerror = t.step_func(unreached);

34 document.body.appendChild(img);	41 document.body.appendChild(img);

35 });	42 });

36 </script>	43 </script>

37 </body>	44 </body>

OLD	NEW