Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 2860073002: [v8] Mark layout tests for rebaseline. (Closed)

Created:
3 years, 7 months ago by Michael Starzinger
Modified:
3 years, 7 months ago
Reviewers:
Michael Achenbach
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[v8] Mark layout tests for rebaseline. The tests in question need to be rebaselined after V8 has been rolled with the new asm.js validator enabled. This feature is not yet enabled. R=machenbach@chromium.org BUG=chromium:718394 NOTRY=true Review-Url: https://codereview.chromium.org/2860073002 Cr-Commit-Position: refs/heads/master@{#469315} Committed: https://chromium.googlesource.com/chromium/src/+/13da7bbd393358ca25773407d2139980b2002133

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Michael Starzinger
PTAL.
3 years, 7 months ago (2017-05-04 12:16:24 UTC) #3
Michael Achenbach
lgtm
3 years, 7 months ago (2017-05-04 12:24:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860073002/1
3 years, 7 months ago (2017-05-04 12:24:14 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 12:27:55 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/13da7bbd393358ca25773407d213...

Powered by Google App Engine
This is Rietveld 408576698