Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(60)

Issue 2860063003: Improve usage documentation of scoped task environments. (Closed)

Created:
1 year, 10 months ago by gab
Modified:
1 year, 10 months ago
CC:
chromium-reviews, vmpstr+watch_chromium.org, robliao+watch_chromium.org, jam, gab+watch_chromium.org, darin-cc_chromium.org, fdoray+watch_chromium.org, danakj+watch_chromium.org, fdoray
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve usage documentation of scoped task environments. And improve information provided by out-of-order destruction of task scheduler and its provided constructs in unit tests. (comes out of discussion on https://codereview.chromium.org/2852333004/) BUG=708584, 689520 TBR=avi@chromium.org (documentation update in test_browser_thread_bundle.h) Review-Url: https://codereview.chromium.org/2860063003 Cr-Commit-Position: refs/heads/master@{#469516} Committed: https://chromium.googlesource.com/chromium/src/+/1f58e951e440d1a57e94536ed34aae1715eedf21

Patch Set 1 #

Total comments: 10

Patch Set 2 : nits + fix nacl compile #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -4 lines) Patch
M base/task_scheduler/scheduler_single_thread_task_runner_manager.cc View 1 3 chunks +29 lines, -4 lines 1 comment Download
M base/test/scoped_task_environment.h View 1 1 chunk +17 lines, -0 lines 0 comments Download
M content/public/test/test_browser_thread_bundle.h View 1 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
gab
Rob PTaL Avi PTaL @ test_browser_thread_bundle.h Thanks!
1 year, 10 months ago (2017-05-04 21:40:32 UTC) #4
robliao
lgtm % nits https://codereview.chromium.org/2860063003/diff/1/base/task_scheduler/scheduler_single_thread_task_runner_manager.cc File base/task_scheduler/scheduler_single_thread_task_runner_manager.cc (right): https://codereview.chromium.org/2860063003/diff/1/base/task_scheduler/scheduler_single_thread_task_runner_manager.cc#newcode288 base/task_scheduler/scheduler_single_thread_task_runner_manager.cc:288: // Note: this will crash if ...
1 year, 10 months ago (2017-05-04 21:54:28 UTC) #5
gab
Thanks, done, TBR avi for documentation update in test_browser_thread_bundle.h (we can TBR doc updates now ...
1 year, 10 months ago (2017-05-04 22:27:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860063003/20001
1 year, 10 months ago (2017-05-04 22:28:45 UTC) #14
Avi (use Gerrit)
lgtm! https://codereview.chromium.org/2860063003/diff/20001/base/task_scheduler/scheduler_single_thread_task_runner_manager.cc File base/task_scheduler/scheduler_single_thread_task_runner_manager.cc (right): https://codereview.chromium.org/2860063003/diff/20001/base/task_scheduler/scheduler_single_thread_task_runner_manager.cc#newcode351 base/task_scheduler/scheduler_single_thread_task_runner_manager.cc:351: "first and destroyed last.\n" Awesome error!
1 year, 10 months ago (2017-05-04 23:10:44 UTC) #15
commit-bot: I haz the power
1 year, 10 months ago (2017-05-04 23:29:02 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1f58e951e440d1a57e94536ed34a...

Powered by Google App Engine
This is Rietveld 408576698