Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1002)

Issue 2860043002: [heap] Add VMState to IncrementalMarking observer (Closed)

Created:
3 years, 7 months ago by Michael Lippautz
Modified:
3 years, 7 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office)
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Add VMState to IncrementalMarking observer BUG=v8:6343 Review-Url: https://codereview.chromium.org/2860043002 Cr-Commit-Position: refs/heads/master@{#45079} Committed: https://chromium.googlesource.com/v8/v8/+/302b06bfe27cfa77e996f025d33e182dc4bd233b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M src/counters.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/incremental-marking.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/heap/incremental-marking.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/heap/incremental-marking-job.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Michael Lippautz
ptal
3 years, 7 months ago (2017-05-04 09:41:47 UTC) #2
ulan
lgtm
3 years, 7 months ago (2017-05-04 09:52:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860043002/1
3 years, 7 months ago (2017-05-04 10:31:13 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 10:32:46 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/302b06bfe27cfa77e996f025d33e182dc4b...

Powered by Google App Engine
This is Rietveld 408576698