chrome/test/data/extensions/active_script/inject_scripts_explicit_hosts/background.js - Issue 286003004: Block tabs.executeScript() from executing until user grants permission

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/active_script/inject_scripts_explicit_hosts/background.js

Issue 286003004: Block tabs.executeScript() from executing until user grants permission (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/data/extensions/active_script/inject_scripts_all_hosts/background.js ('K') | « chrome/test/data/extensions/active_script/inject_scripts_all_hosts/background.js ('k') | chrome/test/data/extensions/active_script/inject_scripts_explicit_hosts/manifest.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/active_script/inject_scripts_explicit_hosts/background.js

diff --git a/chrome/test/data/extensions/active_script/inject_scripts_all_hosts/background.js b/chrome/test/data/extensions/active_script/inject_scripts_explicit_hosts/background.js

similarity index 70%

copy from chrome/test/data/extensions/active_script/inject_scripts_all_hosts/background.js

copy to chrome/test/data/extensions/active_script/inject_scripts_explicit_hosts/background.js

index 309f4d813b0c234c6ad576bdc73954be825edecc..6d90bb6278ab62d20eee9e0c52e821f56e5c7533 100644

--- a/chrome/test/data/extensions/active_script/inject_scripts_all_hosts/background.js

+++ b/chrome/test/data/extensions/active_script/inject_scripts_explicit_hosts/background.js

@@ -5,5 +5,6 @@

chrome.tabs.onUpdated.addListener(function(tabId) {

chrome.tabs.executeScript(

tabId,

- { code: 'chrome.test.sendMessage("inject_scripts_all_hosts");' });

+ { code: "chrome.test.sendMessage('inject succeeded');" });

+ chrome.test.sendMessage('inject attempted');

not at google - send to devlin 2014/05/15 00:12:36 same comments why doesn't this need the loading c

Devlin 2014/05/15 17:45:59 Done.

});