Block tabs.executeScript() from executing until user grants permission

chrome/test/data/extensions/active_script/inject_scripts_all_hosts/background.js

Index: chrome/test/data/extensions/active_script/inject_scripts_all_hosts/background.js
diff --git a/chrome/test/data/extensions/active_script/inject_scripts_all_hosts/background.js b/chrome/test/data/extensions/active_script/inject_scripts_all_hosts/background.js
index 309f4d813b0c234c6ad576bdc73954be825edecc..ea6389bb65d55195bbb2e14983f39a6a9bc285c9 100644
--- a/chrome/test/data/extensions/active_script/inject_scripts_all_hosts/background.js
+++ b/chrome/test/data/extensions/active_script/inject_scripts_all_hosts/background.js
@@ -2,8 +2,12 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-chrome.tabs.onUpdated.addListener(function(tabId) {
+chrome.tabs.onUpdated.addListener(function(tabId, changeInfo) {
+  if (changeInfo.status == 'loading')
+    return;

[not at google - send to devlin, 2014/05/15 00:12:36]

you want to know exactly when the tab is complete, right? in that case you can
do

function(_, _, tab) {
  if (tab.status == 'complete') ...

[Devlin, 2014/05/15 17:45:59]

Actually, the only reason I had it was so that we'd only inject it once.  It
makes a lot more sense to just remove the listener though.  Removed whole thing.

+

[not at google - send to devlin, 2014/05/15 00:12:36]

remove listener here?

[Devlin, 2014/05/15 17:45:59]

Done.

   chrome.tabs.executeScript(
       tabId,
-      { code: 'chrome.test.sendMessage("inject_scripts_all_hosts");' });
+      { code: "chrome.test.sendMessage('inject succeeded');" });

[not at google - send to devlin, 2014/05/15 00:12:36]

javascript can be so ugly. how about

chrome.tabs.executeScript(tabId, {
  code: ...
});

for some reason I didn't ask for that last time.

[Devlin, 2014/05/15 17:45:59]

Sure, done.

+  chrome.test.sendMessage('inject attempted');
 });