Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2860013002: [DevTools] Support multiple sessions in WebDevToolsAgentImpl (Closed)

Created:
3 years, 7 months ago by dgozman
Modified:
3 years, 6 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kinuko+watch, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Support multiple sessions in WebDevToolsAgentImpl BUG=590878 Review-Url: https://codereview.chromium.org/2860013002 Cr-Commit-Position: refs/heads/master@{#477551} Committed: https://chromium.googlesource.com/chromium/src/+/cdc887c27d1270de1006ae0ac972fb0215eef62a

Patch Set 1 #

Patch Set 2 : works? #

Patch Set 3 : rebased #

Patch Set 4 : zero session id fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -122 lines) Patch
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.h View 1 2 3 chunks +12 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 1 2 3 9 chunks +134 lines, -112 lines 0 comments Download

Messages

Total messages: 19 (15 generated)
dgozman
Could you please take a look?
3 years, 6 months ago (2017-06-06 19:29:17 UTC) #4
pfeldman
lgtm
3 years, 6 months ago (2017-06-06 20:29:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860013002/60001
3 years, 6 months ago (2017-06-07 04:43:13 UTC) #16
commit-bot: I haz the power
3 years, 6 months ago (2017-06-07 04:47:29 UTC) #19
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/cdc887c27d1270de1006ae0ac972...

Powered by Google App Engine
This is Rietveld 408576698