Convert some tests to use the driver and prepare for others to be converted

Convert some tests to use the driver and prepare for others to be converted

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/0b59d3f65038f7a95205a043bd95e08cfa5651c4

[Brian Wilkerson, 2017-05-05 19:28:42]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[Brian Wilkerson, 2017-05-05 19:28:42]

Not all of our tests are currently being run with the new driver enabled, and
some won't run without changes. This updates a couple of tests to use the driver
and makes a couple of other changes that will enable other tests to be updated.

[scheglov, 2017-05-05 19:37:12]

LGTM

https://codereview.chromium.org/2859993004/diff/1/pkg/analysis_server/test/se...
File pkg/analysis_server/test/services/completion/completion_target_test.dart
(right):

https://codereview.chromium.org/2859993004/diff/1/pkg/analysis_server/test/se...
pkg/analysis_server/test/services/completion/completion_target_test.dart:42:
AnalysisResult result = await driver.getResult(testSource.fullName);
I think that practically we don't use "testSource" per se, only its path.
That's why we were not returning it from addSource().
Using it is not a bug, just muddles things up a bit.

https://codereview.chromium.org/2859993004/diff/1/pkg/analysis_server/test/se...
File pkg/analysis_server/test/services/correction/sort_members_test.dart
(right):

https://codereview.chromium.org/2859993004/diff/1/pkg/analysis_server/test/se...
pkg/analysis_server/test/services/correction/sort_members_test.dart:810:
AnalysisResult result = await driver.getResult(testSource.fullName);
driver.parseFile() maybe?

[Brian Wilkerson, 2017-05-05 20:20:00]

https://codereview.chromium.org/2859993004/diff/1/pkg/analysis_server/test/se...
File pkg/analysis_server/test/services/completion/completion_target_test.dart
(right):

https://codereview.chromium.org/2859993004/diff/1/pkg/analysis_server/test/se...
pkg/analysis_server/test/services/completion/completion_target_test.dart:42:
AnalysisResult result = await driver.getResult(testSource.fullName);
There are currently over 700 invocations of addSource(). I don't want to verify
that every one of them can be converted to return a path. (It will be much
easier after the rest of the non-driver code is removed.)

https://codereview.chromium.org/2859993004/diff/1/pkg/analysis_server/test/se...
File pkg/analysis_server/test/services/correction/sort_members_test.dart
(right):

https://codereview.chromium.org/2859993004/diff/1/pkg/analysis_server/test/se...
pkg/analysis_server/test/services/correction/sort_members_test.dart:810:
AnalysisResult result = await driver.getResult(testSource.fullName);
Done

[Brian Wilkerson, 2017-05-05 20:20:42]

Description was changed from

==========
Convert some tests to use the driver and prepare for others to be converted
==========

to

==========
Convert some tests to use the driver and prepare for others to be converted

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/0b59d3f65038f7a95205a043bd95e08cfa5651c4
==========

[Brian Wilkerson, 2017-05-05 20:20:43]

Committed patchset #1 (id:1) manually as
0b59d3f65038f7a95205a043bd95e08cfa5651c4 (presubmit successful).