Convert some tests to use the driver and prepare for others to be converted

pkg/analysis_server/test/services/completion/completion_target_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.services.completion.target;
 
+import 'dart:async';
+
 import 'package:analysis_server/src/provisional/completion/dart/completion_target.dart';
 import 'package:analyzer/dart/ast/ast.dart';
+import 'package:analyzer/src/dart/analysis/driver.dart';
 import 'package:analyzer/src/generated/source.dart';
 import 'package:test/test.dart';
 import 'package:test_reflective_loader/test_reflective_loader.dart';
 
 import '../../abstract_context.dart';
 
 main() {
   defineReflectiveSuite(() {
     defineReflectiveTests(CompletionTargetTest);
   });
 }
 
 @reflectiveTest
 class CompletionTargetTest extends AbstractContextTest {
   Source testSource;
   int completionOffset;
   CompletionTarget target;
 
-  void addTestSource(String content) {
+  @override
+  bool get enableNewAnalysisDriver => true;
+
+  Future<Null> addTestSource(String content) async {
     expect(completionOffset, isNull, reason: 'Call addTestSource exactly once');
     completionOffset = content.indexOf('^');
     expect(completionOffset, isNot(equals(-1)), reason: 'missing ^');
     int nextOffset = content.indexOf('^', completionOffset + 1);
     expect(nextOffset, equals(-1), reason: 'too many ^');
     content = content.substring(0, completionOffset) +
         content.substring(completionOffset + 1);
     testSource = addSource('/test.dart', content);
-    CompilationUnit unit = context.parseCompilationUnit(testSource);
-    target = new CompletionTarget.forOffset(unit, completionOffset);
+    AnalysisResult result = await driver.getResult(testSource.fullName);

[scheglov, 2017/05/05 19:37:12]

I think that practically we don't use "testSource" per se, only its path.
That's why we were not returning it from addSource().
Using it is not a bug, just muddles things up a bit.

[Brian Wilkerson, 2017/05/05 20:19:59]

There are currently over 700 invocations of addSource(). I don't want to verify
that every one of them can be converted to return a path. (It will be much
easier after the rest of the non-driver code is removed.)

+    target = new CompletionTarget.forOffset(result.unit, completionOffset);
   }
 
-  void assertTarget(entityText, nodeText,
-      {int argIndex: null, bool isFunctionalArgument: false}) {
+  Future<Null> assertTarget(entityText, nodeText,
+      {int argIndex: null, bool isFunctionalArgument: false}) async {
     void assertCommon() {
       expect(target.entity.toString(), entityText, reason: 'entity');
       expect(target.containingNode.toString(), nodeText,
           reason: 'containingNode');
       expect(target.argIndex, argIndex, reason: 'argIndex');
     }
 
     // Assert with parsed unit
     assertCommon();
-    CompilationUnit unit =
-        context.resolveCompilationUnit2(testSource, testSource);
-    target = new CompletionTarget.forOffset(unit, completionOffset);
+    AnalysisResult result = await driver.getResult(testSource.fullName);
+    target = new CompletionTarget.forOffset(result.unit, completionOffset);
     // Assert more with resolved unit
     assertCommon();
     expect(target.isFunctionalArgument(), isFunctionalArgument);
   }
 
-  test_ArgumentList_InstanceCreationExpression() {
+  test_ArgumentList_InstanceCreationExpression() async {
     // ArgumentList  InstanceCreationExpression  Block
-    addTestSource('main() {new Foo(^)}');
-    assertTarget(')', '()', argIndex: 0);
-  }
-
-  test_ArgumentList_InstanceCreationExpression2() {
+    await addTestSource('main() {new Foo(^)}');
+    await assertTarget(')', '()', argIndex: 0);
+  }
+
+  test_ArgumentList_InstanceCreationExpression2() async {
     // ArgumentList  InstanceCreationExpression  Block
-    addTestSource('main() {new Foo(a,^)}');
-    assertTarget(')', '(a)', argIndex: 1);
-  }
-
-  test_ArgumentList_InstanceCreationExpression_functionArg2() {
+    await addTestSource('main() {new Foo(a,^)}');
+    await assertTarget(')', '(a)', argIndex: 1);
+  }
+
+  test_ArgumentList_InstanceCreationExpression_functionArg2() async {
     // ArgumentList  InstanceCreationExpression  Block
-    addTestSource('main() {new B(^)} class B{B(f()){}}');
-    assertTarget(')', '()', argIndex: 0, isFunctionalArgument: true);
-  }
-
-  test_ArgumentList_InstanceCreationExpression_functionArg3() {
+    await addTestSource('main() {new B(^)} class B{B(f()){}}');
+    await assertTarget(')', '()', argIndex: 0, isFunctionalArgument: true);
+  }
+
+  test_ArgumentList_InstanceCreationExpression_functionArg3() async {
     // ArgumentList  InstanceCreationExpression  Block
-    addTestSource('main() {new B(1, f: ^)} class B{B(int i, {f()}){}}');
-    assertTarget('', 'f: ', argIndex: 1, isFunctionalArgument: true);
-  }
-
-  test_ArgumentList_MethodInvocation() {
-    // ArgumentList  MethodInvocation  Block
-    addTestSource('main() {foo(^)}');
-    assertTarget(')', '()', argIndex: 0);
-  }
-
-  test_ArgumentList_MethodInvocation2() {
-    // ArgumentList  MethodInvocation  Block
-    addTestSource('main() {foo(^n)}');
-    assertTarget('n', '(n)', argIndex: 0);
-  }
-
-  test_ArgumentList_MethodInvocation3() {
-    // ArgumentList  MethodInvocation  Block
-    addTestSource('main() {foo(n^)}');
-    assertTarget('n', '(n)', argIndex: 0);
-  }
-
-  test_ArgumentList_MethodInvocation3a() {
-    // ArgumentList  MethodInvocation  Block
-    addTestSource('main() {foo((n)^)}');
-    assertTarget(')', '((n))', argIndex: 0);
-  }
-
-  test_ArgumentList_MethodInvocation4() {
-    // ArgumentList  MethodInvocation  Block
-    addTestSource('main() {foo(n,^)}');
-    assertTarget(')', '(n)', argIndex: 1);
-  }
-
-  test_ArgumentList_MethodInvocation_functionArg() {
-    // ArgumentList  MethodInvocation  Block
-    addTestSource('main() {foo(^)} foo(f()) {}');
-    assertTarget(')', '()', argIndex: 0, isFunctionalArgument: true);
-  }
-
-  test_ArgumentList_MethodInvocation_functionArg2() {
-    // ArgumentList  MethodInvocation  Block
-    addTestSource('main() {new B().boo(^)} class B{boo(f()){}}');
-    assertTarget(')', '()', argIndex: 0, isFunctionalArgument: true);
-  }
-
-  test_ArgumentList_MethodInvocation_functionArg3() {
-    // ArgumentList  MethodInvocation  Block
-    addTestSource('main() {foo(f: ^)} foo({f()}) {}');
-    assertTarget('', 'f: ', argIndex: 0, isFunctionalArgument: true);
-  }
-
-  test_ArgumentList_MethodInvocation_functionArg4() {
-    // ArgumentList  MethodInvocation  Block
-    addTestSource('main() {new B().boo(f: ^)} class B{boo({f()}){}}');
-    assertTarget('', 'f: ', argIndex: 0, isFunctionalArgument: true);
-  }
-
-  test_AsExpression_identifier() {
+    await addTestSource('main() {new B(1, f: ^)} class B{B(int i, {f()}){}}');
+    await assertTarget('', 'f: ', argIndex: 1, isFunctionalArgument: true);
+  }
+
+  test_ArgumentList_MethodInvocation() async {
+    // ArgumentList  MethodInvocation  Block
+    await addTestSource('main() {foo(^)}');
+    await assertTarget(')', '()', argIndex: 0);
+  }
+
+  test_ArgumentList_MethodInvocation2() async {
+    // ArgumentList  MethodInvocation  Block
+    await addTestSource('main() {foo(^n)}');
+    await assertTarget('n', '(n)', argIndex: 0);
+  }
+
+  test_ArgumentList_MethodInvocation3() async {
+    // ArgumentList  MethodInvocation  Block
+    await addTestSource('main() {foo(n^)}');
+    await assertTarget('n', '(n)', argIndex: 0);
+  }
+
+  test_ArgumentList_MethodInvocation3a() async {
+    // ArgumentList  MethodInvocation  Block
+    await addTestSource('main() {foo((n)^)}');
+    await assertTarget(')', '((n))', argIndex: 0);
+  }
+
+  test_ArgumentList_MethodInvocation4() async {
+    // ArgumentList  MethodInvocation  Block
+    await addTestSource('main() {foo(n,^)}');
+    await assertTarget(')', '(n)', argIndex: 1);
+  }
+
+  test_ArgumentList_MethodInvocation_functionArg() async {
+    // ArgumentList  MethodInvocation  Block
+    await addTestSource('main() {foo(^)} foo(f()) {}');
+    await assertTarget(')', '()', argIndex: 0, isFunctionalArgument: true);
+  }
+
+  test_ArgumentList_MethodInvocation_functionArg2() async {
+    // ArgumentList  MethodInvocation  Block
+    await addTestSource('main() {new B().boo(^)} class B{boo(f()){}}');
+    await assertTarget(')', '()', argIndex: 0, isFunctionalArgument: true);
+  }
+
+  test_ArgumentList_MethodInvocation_functionArg3() async {
+    // ArgumentList  MethodInvocation  Block
+    await addTestSource('main() {foo(f: ^)} foo({f()}) {}');
+    await assertTarget('', 'f: ', argIndex: 0, isFunctionalArgument: true);
+  }
+
+  test_ArgumentList_MethodInvocation_functionArg4() async {
+    // ArgumentList  MethodInvocation  Block
+    await addTestSource('main() {new B().boo(f: ^)} class B{boo({f()}){}}');
+    await assertTarget('', 'f: ', argIndex: 0, isFunctionalArgument: true);
+  }
+
+  test_AsExpression_identifier() async {
     // SimpleIdentifier  TypeName  AsExpression
-    addTestSource('class A {var b; X _c; foo() {var a; (a^ as String).foo();}');
-    assertTarget('a as String', '(a as String)');
-  }
-
-  test_AsExpression_keyword() {
+    await addTestSource(
+        'class A {var b; X _c; foo() {var a; (a^ as String).foo();}');
+    await assertTarget('a as String', '(a as String)');
+  }
+
+  test_AsExpression_keyword() async {
     // SimpleIdentifier  TypeName  AsExpression
-    addTestSource('class A {var b; X _c; foo() {var a; (a ^as String).foo();}');
-    assertTarget('as', 'a as String');
-  }
-
-  test_AsExpression_keyword2() {
+    await addTestSource(
+        'class A {var b; X _c; foo() {var a; (a ^as String).foo();}');
+    await assertTarget('as', 'a as String');
+  }
+
+  test_AsExpression_keyword2() async {
     // SimpleIdentifier  TypeName  AsExpression
-    addTestSource('class A {var b; X _c; foo() {var a; (a a^s String).foo();}');
-    assertTarget('as', 'a as String');
-  }
-
-  test_AsExpression_keyword3() {
+    await addTestSource(
+        'class A {var b; X _c; foo() {var a; (a a^s String).foo();}');
+    await assertTarget('as', 'a as String');
+  }
+
+  test_AsExpression_keyword3() async {
     // SimpleIdentifier  TypeName  AsExpression
-    addTestSource('class A {var b; X _c; foo() {var a; (a as^ String).foo();}');
-    assertTarget('as', 'a as String');
-  }
-
-  test_AsExpression_type() {
+    await addTestSource(
+        'class A {var b; X _c; foo() {var a; (a as^ String).foo();}');
+    await assertTarget('as', 'a as String');
+  }
+
+  test_AsExpression_type() async {
     // SimpleIdentifier  TypeName  AsExpression
-    addTestSource('class A {var b; X _c; foo() {var a; (a as ^String).foo();}');
-    assertTarget('String', 'a as String');
-  }
-
-  test_Block() {
+    await addTestSource(
+        'class A {var b; X _c; foo() {var a; (a as ^String).foo();}');
+    await assertTarget('String', 'a as String');
+  }
+
+  test_Block() async {
     // Block
-    addTestSource('main() {^}');
-    assertTarget('}', '{}');
-  }
-
-  test_Block_keyword() {
-    addTestSource('class C { static C get instance => null; } main() {C.in^}');
-    assertTarget('in', 'C.in');
-  }
-
-  test_Block_keyword2() {
-    addTestSource('class C { static C get instance => null; } main() {C.i^n}');
-    assertTarget('in', 'C.in');
-  }
-
-  test_FormalParameter_partialType() {
+    await addTestSource('main() {^}');
+    await assertTarget('}', '{}');
+  }
+
+  test_Block_keyword() async {
+    await addTestSource(
+        'class C { static C get instance => null; } main() {C.in^}');
+    await assertTarget('in', 'C.in');
+  }
+
+  test_Block_keyword2() async {
+    await addTestSource(
+        'class C { static C get instance => null; } main() {C.i^n}');
+    await assertTarget('in', 'C.in');
+  }
+
+  test_FormalParameter_partialType() async {
     // SimpleIdentifier  PrefixedIdentifier  TypeName
-    addTestSource('foo(b.^ f) { }');
-    assertTarget('f', 'b.f');
-  }
-
-  test_FormalParameter_partialType2() {
+    await addTestSource('foo(b.^ f) { }');
+    await assertTarget('f', 'b.f');
+  }
+
+  test_FormalParameter_partialType2() async {
     // SimpleIdentifier  PrefixedIdentifier  TypeName
-    addTestSource('foo(b.z^ f) { }');
-    assertTarget('z', 'b.z');
-  }
-
-  test_FormalParameter_partialType3() {
+    await addTestSource('foo(b.z^ f) { }');
+    await assertTarget('z', 'b.z');
+  }
+
+  test_FormalParameter_partialType3() async {
     // SimpleIdentifier  PrefixedIdentifier  TypeName
-    addTestSource('foo(b.^) { }');
-    assertTarget('', 'b.');
-  }
-
-  test_FormalParameterList() {
+    await addTestSource('foo(b.^) { }');
+    await assertTarget('', 'b.');
+  }
+
+  test_FormalParameterList() async {
     // Token  FormalParameterList  FunctionExpression
-    addTestSource('foo(^) { }');
-    assertTarget(')', '()');
-  }
-
-  test_FunctionDeclaration_inLineComment() {
+    await addTestSource('foo(^) { }');
+    await assertTarget(')', '()');
+  }
+
+  test_FunctionDeclaration_inLineComment() async {
     // Comment  CompilationUnit
-    addTestSource('''
+    await addTestSource('''
       // normal comment ^
       zoo(z) { } String name;''');
-    assertTarget('// normal comment ', 'zoo(z) {} String name;');
-  }
-
-  test_FunctionDeclaration_inLineComment2() {
+    await assertTarget('// normal comment ', 'zoo(z) {} String name;');
+  }
+
+  test_FunctionDeclaration_inLineComment2() async {
     // Comment  CompilationUnit
-    addTestSource('''
+    await addTestSource('''
       // normal ^comment
       zoo(z) { } String name;''');
-    assertTarget('// normal comment', 'zoo(z) {} String name;');
-  }
-
-  test_FunctionDeclaration_inLineComment3() {
+    await assertTarget('// normal comment', 'zoo(z) {} String name;');
+  }
+
+  test_FunctionDeclaration_inLineComment3() async {
     // Comment  CompilationUnit
-    addTestSource('''
+    await addTestSource('''
       // normal comment ^
       // normal comment 2
       zoo(z) { } String name;''');
-    assertTarget('// normal comment ', 'zoo(z) {} String name;');
-  }
-
-  test_FunctionDeclaration_inLineComment4() {
+    await assertTarget('// normal comment ', 'zoo(z) {} String name;');
+  }
+
+  test_FunctionDeclaration_inLineComment4() async {
     // Comment  CompilationUnit
-    addTestSource('''
+    await addTestSource('''
       // normal comment
       // normal comment 2^
       zoo(z) { } String name;''');
-    assertTarget('// normal comment 2', 'zoo(z) {} String name;');
-  }
-
-  test_FunctionDeclaration_inLineDocComment() {
+    await assertTarget('// normal comment 2', 'zoo(z) {} String name;');
+  }
+
+  test_FunctionDeclaration_inLineDocComment() async {
     // Comment  FunctionDeclaration  CompilationUnit
-    addTestSource('''
+    await addTestSource('''
       /// some dartdoc ^
       zoo(z) { } String name;''');
-    assertTarget('/// some dartdoc ', '');
-    expect(target.containingNode is Comment, isTrue);
-    expect(target.containingNode.parent.toSource(), 'zoo(z) {}');
-  }
-
-  test_FunctionDeclaration_inLineDocComment2() {
+    await assertTarget('/// some dartdoc ', '');
+    expect(target.containingNode is Comment, isTrue);
+    expect(target.containingNode.parent.toSource(), 'zoo(z) {}');
+  }
+
+  test_FunctionDeclaration_inLineDocComment2() async {
     // Comment  FunctionDeclaration  CompilationUnit
-    addTestSource('''
+    await addTestSource('''
       /// some ^dartdoc
       zoo(z) { } String name;''');
-    assertTarget('/// some dartdoc', '');
-    expect(target.containingNode is Comment, isTrue);
-    expect(target.containingNode.parent.toSource(), 'zoo(z) {}');
-  }
-
-  test_FunctionDeclaration_inStarComment() {
+    await assertTarget('/// some dartdoc', '');
+    expect(target.containingNode is Comment, isTrue);
+    expect(target.containingNode.parent.toSource(), 'zoo(z) {}');
+  }
+
+  test_FunctionDeclaration_inStarComment() async {
     // Comment  CompilationUnit
-    addTestSource('/* ^ */ zoo(z) {} String name;');
-    assertTarget('/*  */', 'zoo(z) {} String name;');
-  }
-
-  test_FunctionDeclaration_inStarComment2() {
+    await addTestSource('/* ^ */ zoo(z) {} String name;');
+    await assertTarget('/*  */', 'zoo(z) {} String name;');
+  }
+
+  test_FunctionDeclaration_inStarComment2() async {
     // Comment  CompilationUnit
-    addTestSource('/*  *^/ zoo(z) {} String name;');
-    assertTarget('/*  */', 'zoo(z) {} String name;');
-  }
-
-  test_FunctionDeclaration_inStarDocComment() {
+    await addTestSource('/*  *^/ zoo(z) {} String name;');
+    await assertTarget('/*  */', 'zoo(z) {} String name;');
+  }
+
+  test_FunctionDeclaration_inStarDocComment() async {
     // Comment  FunctionDeclaration  CompilationUnit
-    addTestSource('/** ^ */ zoo(z) { } String name;');
-    assertTarget('/**  */', '');
-    expect(target.containingNode is Comment, isTrue);
-    expect(target.containingNode.parent.toSource(), 'zoo(z) {}');
-  }
-
-  test_FunctionDeclaration_inStarDocComment2() {
+    await addTestSource('/** ^ */ zoo(z) { } String name;');
+    await assertTarget('/**  */', '');
+    expect(target.containingNode is Comment, isTrue);
+    expect(target.containingNode.parent.toSource(), 'zoo(z) {}');
+  }
+
+  test_FunctionDeclaration_inStarDocComment2() async {
     // Comment  FunctionDeclaration  CompilationUnit
-    addTestSource('/**  *^/ zoo(z) { } String name;');
-    assertTarget('/**  */', '');
-    expect(target.containingNode is Comment, isTrue);
-    expect(target.containingNode.parent.toSource(), 'zoo(z) {}');
-  }
-
-  test_FunctionDeclaration_returnType() {
+    await addTestSource('/**  *^/ zoo(z) { } String name;');
+    await assertTarget('/**  */', '');
+    expect(target.containingNode is Comment, isTrue);
+    expect(target.containingNode.parent.toSource(), 'zoo(z) {}');
+  }
+
+  test_FunctionDeclaration_returnType() async {
     // CompilationUnit
-    addTestSource('^ zoo(z) { } String name;');
-    assertTarget('zoo(z) {}', 'zoo(z) {} String name;');
-  }
-
-  test_FunctionDeclaration_returnType_afterLineComment() {
+    await addTestSource('^ zoo(z) { } String name;');
+    await assertTarget('zoo(z) {}', 'zoo(z) {} String name;');
+  }
+
+  test_FunctionDeclaration_returnType_afterLineComment() async {
     // FunctionDeclaration  CompilationUnit
-    addTestSource('''
+    await addTestSource('''
       // normal comment
       ^ zoo(z) {} String name;''');
-    assertTarget('zoo(z) {}', 'zoo(z) {} String name;');
-  }
-
-  test_FunctionDeclaration_returnType_afterLineComment2() {
+    await assertTarget('zoo(z) {}', 'zoo(z) {} String name;');
+  }
+
+  test_FunctionDeclaration_returnType_afterLineComment2() async {
     // FunctionDeclaration  CompilationUnit
     // TOD(danrubel) left align all test source
-    addTestSource('''
+    await addTestSource('''
 // normal comment
 ^ zoo(z) {} String name;''');
-    assertTarget('zoo(z) {}', 'zoo(z) {} String name;');
-  }
-
-  test_FunctionDeclaration_returnType_afterLineDocComment() {
+    await assertTarget('zoo(z) {}', 'zoo(z) {} String name;');
+  }
+
+  test_FunctionDeclaration_returnType_afterLineDocComment() async {
     // SimpleIdentifier  FunctionDeclaration  CompilationUnit
-    addTestSource('''
+    await addTestSource('''
       /// some dartdoc
       ^ zoo(z) { } String name; ''');
-    assertTarget('zoo', 'zoo(z) {}');
-  }
-
-  test_FunctionDeclaration_returnType_afterLineDocComment2() {
+    await assertTarget('zoo', 'zoo(z) {}');
+  }
+
+  test_FunctionDeclaration_returnType_afterLineDocComment2() async {
     // SimpleIdentifier  FunctionDeclaration  CompilationUnit
-    addTestSource('''
+    await addTestSource('''
 /// some dartdoc
 ^ zoo(z) { } String name;''');
-    assertTarget('zoo', 'zoo(z) {}');
-  }
-
-  test_FunctionDeclaration_returnType_afterStarComment() {
+    await assertTarget('zoo', 'zoo(z) {}');
+  }
+
+  test_FunctionDeclaration_returnType_afterStarComment() async {
     // CompilationUnit
-    addTestSource('/* */ ^ zoo(z) { } String name;');
-    assertTarget('zoo(z) {}', 'zoo(z) {} String name;');
-  }
-
-  test_FunctionDeclaration_returnType_afterStarComment2() {
+    await addTestSource('/* */ ^ zoo(z) { } String name;');
+    await assertTarget('zoo(z) {}', 'zoo(z) {} String name;');
+  }
+
+  test_FunctionDeclaration_returnType_afterStarComment2() async {
     // CompilationUnit
-    addTestSource('/* */^ zoo(z) { } String name;');
-    assertTarget('zoo(z) {}', 'zoo(z) {} String name;');
-  }
-
-  test_FunctionDeclaration_returnType_afterStarDocComment() {
+    await addTestSource('/* */^ zoo(z) { } String name;');
+    await assertTarget('zoo(z) {}', 'zoo(z) {} String name;');
+  }
+
+  test_FunctionDeclaration_returnType_afterStarDocComment() async {
     // FunctionDeclaration  CompilationUnit
-    addTestSource('/** */ ^ zoo(z) { } String name;');
-    assertTarget('zoo', 'zoo(z) {}');
-  }
-
-  test_FunctionDeclaration_returnType_afterStarDocComment2() {
+    await addTestSource('/** */ ^ zoo(z) { } String name;');
+    await assertTarget('zoo', 'zoo(z) {}');
+  }
+
+  test_FunctionDeclaration_returnType_afterStarDocComment2() async {
     // FunctionDeclaration  CompilationUnit
-    addTestSource('/** */^ zoo(z) { } String name;');
-    assertTarget('zoo', 'zoo(z) {}');
-  }
-
-  test_InstanceCreationExpression_identifier() {
+    await addTestSource('/** */^ zoo(z) { } String name;');
+    await assertTarget('zoo', 'zoo(z) {}');
+  }
+
+  test_InstanceCreationExpression_identifier() async {
     // InstanceCreationExpression  ExpressionStatement  Block
-    addTestSource('class C {foo(){var f; {var x;} new ^C();}}');
-    assertTarget('C', 'new C()');
-  }
-
-  test_InstanceCreationExpression_keyword() {
+    await addTestSource('class C {foo(){var f; {var x;} new ^C();}}');
+    await assertTarget('C', 'new C()');
+  }
+
+  test_InstanceCreationExpression_keyword() async {
     // InstanceCreationExpression  ExpressionStatement  Block
-    addTestSource('class C {foo(){var f; {var x;} new^ }}');
-    assertTarget('new ();', '{var f; {var x;} new ();}');
-  }
-
-  test_InstanceCreationExpression_keyword2() {
+    await addTestSource('class C {foo(){var f; {var x;} new^ }}');
+    await assertTarget('new ();', '{var f; {var x;} new ();}');
+  }
+
+  test_InstanceCreationExpression_keyword2() async {
     // InstanceCreationExpression  ExpressionStatement  Block
-    addTestSource('class C {foo(){var f; {var x;} new^ C();}}');
-    assertTarget('new C();', '{var f; {var x;} new C();}');
-  }
-
-  test_MapLiteralEntry() {
+    await addTestSource('class C {foo(){var f; {var x;} new^ C();}}');
+    await assertTarget('new C();', '{var f; {var x;} new C();}');
+  }
+
+  test_MapLiteralEntry() async {
     // MapLiteralEntry  MapLiteral  VariableDeclaration
-    addTestSource('foo = {^');
-    assertTarget(' : ', '{ : }');
-  }
-
-  test_MapLiteralEntry1() {
+    await addTestSource('foo = {^');
+    await assertTarget(' : ', '{ : }');
+  }
+
+  test_MapLiteralEntry1() async {
     // MapLiteralEntry  MapLiteral  VariableDeclaration
-    addTestSource('foo = {T^');
-    assertTarget('T : ', '{T : }');
-  }
-
-  test_MapLiteralEntry2() {
+    await addTestSource('foo = {T^');
+    await assertTarget('T : ', '{T : }');
+  }
+
+  test_MapLiteralEntry2() async {
     // SimpleIdentifier  MapLiteralEntry  MapLiteral  VariableDeclaration
-    addTestSource('foo = {7:T^};');
-    assertTarget('T', '7 : T');
-  }
-
-  test_MethodDeclaration_inLineComment() {
+    await addTestSource('foo = {7:T^};');
+    await assertTarget('T', '7 : T');
+  }
+
+  test_MethodDeclaration_inLineComment() async {
     // Comment  ClassDeclaration  CompilationUnit
-    addTestSource('''
+    await addTestSource('''
       class C2 {
         // normal comment ^
         zoo(z) { } String name; }''');
-    assertTarget('// normal comment ', 'class C2 {zoo(z) {} String name;}');
-  }
-
-  test_MethodDeclaration_inLineComment2() {
+    await assertTarget(
+        '// normal comment ', 'class C2 {zoo(z) {} String name;}');
+  }
+
+  test_MethodDeclaration_inLineComment2() async {
     // Comment  ClassDeclaration  CompilationUnit
-    addTestSource('''
+    await addTestSource('''
       class C2 {
         // normal ^comment
         zoo(z) { } String name; }''');
-    assertTarget('// normal comment', 'class C2 {zoo(z) {} String name;}');
-  }
-
-  test_MethodDeclaration_inLineComment3() {
+    await assertTarget(
+        '// normal comment', 'class C2 {zoo(z) {} String name;}');
+  }
+
+  test_MethodDeclaration_inLineComment3() async {
     // Comment  ClassDeclaration  CompilationUnit
-    addTestSource('''
+    await addTestSource('''
       class C2 {
         // normal comment ^
         // normal comment 2
         zoo(z) { } String name; }''');
-    assertTarget('// normal comment ', 'class C2 {zoo(z) {} String name;}');
-  }
-
-  test_MethodDeclaration_inLineComment4() {
+    await assertTarget(
+        '// normal comment ', 'class C2 {zoo(z) {} String name;}');
+  }
+
+  test_MethodDeclaration_inLineComment4() async {
     // Comment  ClassDeclaration  CompilationUnit
-    addTestSource('''
+    await addTestSource('''
       class C2 {
         // normal comment
         // normal comment 2^
         zoo(z) { } String name; }''');
-    assertTarget('// normal comment 2', 'class C2 {zoo(z) {} String name;}');
-  }
-
-  test_MethodDeclaration_inLineDocComment() {
+    await assertTarget(
+        '// normal comment 2', 'class C2 {zoo(z) {} String name;}');
+  }
+
+  test_MethodDeclaration_inLineDocComment() async {
     // Comment  MethodDeclaration  ClassDeclaration  CompilationUnit
-    addTestSource('''
+    await addTestSource('''
       class C2 {
         /// some dartdoc ^
         zoo(z) { } String name; }''');
-    assertTarget('/// some dartdoc ', '');
-    expect(target.containingNode is Comment, isTrue);
-    expect(target.containingNode.parent.toSource(), 'zoo(z) {}');
-  }
-
-  test_MethodDeclaration_inLineDocComment2() {
+    await assertTarget('/// some dartdoc ', '');
+    expect(target.containingNode is Comment, isTrue);
+    expect(target.containingNode.parent.toSource(), 'zoo(z) {}');
+  }
+
+  test_MethodDeclaration_inLineDocComment2() async {
     // Comment  MethodDeclaration  ClassDeclaration  CompilationUnit
-    addTestSource('''
+    await addTestSource('''
       class C2 {
         /// some ^dartdoc
         zoo(z) { } String name; }''');
-    assertTarget('/// some dartdoc', '');
-    expect(target.containingNode is Comment, isTrue);
-    expect(target.containingNode.parent.toSource(), 'zoo(z) {}');
-  }
-
-  test_MethodDeclaration_inStarComment() {
+    await assertTarget('/// some dartdoc', '');
+    expect(target.containingNode is Comment, isTrue);
+    expect(target.containingNode.parent.toSource(), 'zoo(z) {}');
+  }
+
+  test_MethodDeclaration_inStarComment() async {
     // Comment  ClassDeclaration  CompilationUnit
-    addTestSource('class C2 {/* ^ */ zoo(z) {} String name;}');
-    assertTarget('/*  */', 'class C2 {zoo(z) {} String name;}');
-  }
-
-  test_MethodDeclaration_inStarComment2() {
+    await addTestSource('class C2 {/* ^ */ zoo(z) {} String name;}');
+    await assertTarget('/*  */', 'class C2 {zoo(z) {} String name;}');
+  }
+
+  test_MethodDeclaration_inStarComment2() async {
     // Comment  ClassDeclaration  CompilationUnit
-    addTestSource('class C2 {/*  *^/ zoo(z) {} String name;}');
-    assertTarget('/*  */', 'class C2 {zoo(z) {} String name;}');
-  }
-
-  test_MethodDeclaration_inStarDocComment() {
+    await addTestSource('class C2 {/*  *^/ zoo(z) {} String name;}');
+    await assertTarget('/*  */', 'class C2 {zoo(z) {} String name;}');
+  }
+
+  test_MethodDeclaration_inStarDocComment() async {
     // Comment  MethodDeclaration  ClassDeclaration  CompilationUnit
-    addTestSource('class C2 {/** ^ */ zoo(z) { } String name; }');
-    assertTarget('/**  */', '');
-    expect(target.containingNode is Comment, isTrue);
-    expect(target.containingNode.parent.toSource(), 'zoo(z) {}');
-  }
-
-  test_MethodDeclaration_inStarDocComment2() {
+    await addTestSource('class C2 {/** ^ */ zoo(z) { } String name; }');
+    await assertTarget('/**  */', '');
+    expect(target.containingNode is Comment, isTrue);
+    expect(target.containingNode.parent.toSource(), 'zoo(z) {}');
+  }
+
+  test_MethodDeclaration_inStarDocComment2() async {
     // Comment  MethodDeclaration  ClassDeclaration  CompilationUnit
-    addTestSource('class C2 {/**  *^/ zoo(z) { } String name; }');
-    assertTarget('/**  */', '');
-    expect(target.containingNode is Comment, isTrue);
-    expect(target.containingNode.parent.toSource(), 'zoo(z) {}');
-  }
-
-  test_MethodDeclaration_returnType() {
+    await addTestSource('class C2 {/**  *^/ zoo(z) { } String name; }');
+    await assertTarget('/**  */', '');
+    expect(target.containingNode is Comment, isTrue);
+    expect(target.containingNode.parent.toSource(), 'zoo(z) {}');
+  }
+
+  test_MethodDeclaration_returnType() async {
     // ClassDeclaration  CompilationUnit
-    addTestSource('class C2 {^ zoo(z) { } String name; }');
-    assertTarget('zoo(z) {}', 'class C2 {zoo(z) {} String name;}');
-  }
-
-  test_MethodDeclaration_returnType_afterLineComment() {
+    await addTestSource('class C2 {^ zoo(z) { } String name; }');
+    await assertTarget('zoo(z) {}', 'class C2 {zoo(z) {} String name;}');
+  }
+
+  test_MethodDeclaration_returnType_afterLineComment() async {
     // MethodDeclaration  ClassDeclaration  CompilationUnit
-    addTestSource('''
+    await addTestSource('''
       class C2 {
         // normal comment
         ^ zoo(z) {} String name;}''');
-    assertTarget('zoo(z) {}', 'class C2 {zoo(z) {} String name;}');
-  }
-
-  test_MethodDeclaration_returnType_afterLineComment2() {
+    await assertTarget('zoo(z) {}', 'class C2 {zoo(z) {} String name;}');
+  }
+
+  test_MethodDeclaration_returnType_afterLineComment2() async {
     // MethodDeclaration  ClassDeclaration  CompilationUnit
     // TOD(danrubel) left align all test source
-    addTestSource('''
+    await addTestSource('''
 class C2 {
   // normal comment
 ^ zoo(z) {} String name;}''');
-    assertTarget('zoo(z) {}', 'class C2 {zoo(z) {} String name;}');
-  }
-
-  test_MethodDeclaration_returnType_afterLineDocComment() {
+    await assertTarget('zoo(z) {}', 'class C2 {zoo(z) {} String name;}');
+  }
+
+  test_MethodDeclaration_returnType_afterLineDocComment() async {
     // SimpleIdentifier  MethodDeclaration  ClassDeclaration  CompilationUnit
-    addTestSource('''
+    await addTestSource('''
       class C2 {
         /// some dartdoc
         ^ zoo(z) { } String name; }''');
-    assertTarget('zoo', 'zoo(z) {}');
-  }
-
-  test_MethodDeclaration_returnType_afterLineDocComment2() {
+    await assertTarget('zoo', 'zoo(z) {}');
+  }
+
+  test_MethodDeclaration_returnType_afterLineDocComment2() async {
     // SimpleIdentifier  MethodDeclaration  ClassDeclaration  CompilationUnit
-    addTestSource('''
+    await addTestSource('''
 class C2 {
   /// some dartdoc
 ^ zoo(z) { } String name; }''');
-    assertTarget('zoo', 'zoo(z) {}');
-  }
-
-  test_MethodDeclaration_returnType_afterStarComment() {
+    await assertTarget('zoo', 'zoo(z) {}');
+  }
+
+  test_MethodDeclaration_returnType_afterStarComment() async {
     // ClassDeclaration  CompilationUnit
-    addTestSource('class C2 {/* */ ^ zoo(z) { } String name; }');
-    assertTarget('zoo(z) {}', 'class C2 {zoo(z) {} String name;}');
-  }
-
-  test_MethodDeclaration_returnType_afterStarComment2() {
+    await addTestSource('class C2 {/* */ ^ zoo(z) { } String name; }');
+    await assertTarget('zoo(z) {}', 'class C2 {zoo(z) {} String name;}');
+  }
+
+  test_MethodDeclaration_returnType_afterStarComment2() async {
     // ClassDeclaration  CompilationUnit
-    addTestSource('class C2 {/* */^ zoo(z) { } String name; }');
-    assertTarget('zoo(z) {}', 'class C2 {zoo(z) {} String name;}');
-  }
-
-  test_MethodDeclaration_returnType_afterStarDocComment() {
+    await addTestSource('class C2 {/* */^ zoo(z) { } String name; }');
+    await assertTarget('zoo(z) {}', 'class C2 {zoo(z) {} String name;}');
+  }
+
+  test_MethodDeclaration_returnType_afterStarDocComment() async {
     // MethodDeclaration  ClassDeclaration  CompilationUnit
-    addTestSource('class C2 {/** */ ^ zoo(z) { } String name; }');
-    assertTarget('zoo', 'zoo(z) {}');
-  }
-
-  test_MethodDeclaration_returnType_afterStarDocComment2() {
+    await addTestSource('class C2 {/** */ ^ zoo(z) { } String name; }');
+    await assertTarget('zoo', 'zoo(z) {}');
+  }
+
+  test_MethodDeclaration_returnType_afterStarDocComment2() async {
     // MethodDeclaration  ClassDeclaration  CompilationUnit
-    addTestSource('class C2 {/** */^ zoo(z) { } String name; }');
-    assertTarget('zoo', 'zoo(z) {}');
-  }
-
-  test_SwitchStatement_c() {
+    await addTestSource('class C2 {/** */^ zoo(z) { } String name; }');
+    await assertTarget('zoo', 'zoo(z) {}');
+  }
+
+  test_SwitchStatement_c() async {
     // Token('c') SwitchStatement
-    addTestSource('main() { switch(x) {c^} }');
-    assertTarget('}', 'switch (x) {}');
-  }
-
-  test_SwitchStatement_c2() {
+    await addTestSource('main() { switch(x) {c^} }');
+    await assertTarget('}', 'switch (x) {}');
+  }
+
+  test_SwitchStatement_c2() async {
     // Token('c') SwitchStatement
-    addTestSource('main() { switch(x) { c^ } }');
-    assertTarget('}', 'switch (x) {}');
-  }
-
-  test_SwitchStatement_empty() {
+    await addTestSource('main() { switch(x) { c^ } }');
+    await assertTarget('}', 'switch (x) {}');
+  }
+
+  test_SwitchStatement_empty() async {
     // SwitchStatement
-    addTestSource('main() { switch(x) {^} }');
-    assertTarget('}', 'switch (x) {}');
-  }
-
-  test_SwitchStatement_empty2() {
+    await addTestSource('main() { switch(x) {^} }');
+    await assertTarget('}', 'switch (x) {}');
+  }
+
+  test_SwitchStatement_empty2() async {
     // SwitchStatement
-    addTestSource('main() { switch(x) { ^ } }');
-    assertTarget('}', 'switch (x) {}');
-  }
-
-  test_TypeArgumentList() {
+    await addTestSource('main() { switch(x) { ^ } }');
+    await assertTarget('}', 'switch (x) {}');
+  }
+
+  test_TypeArgumentList() async {
     // TypeName  TypeArgumentList  TypeName
-    addTestSource('main() { C<^> c; }');
-    assertTarget('', '<>');
-  }
-
-  test_TypeArgumentList2() {
+    await addTestSource('main() { C<^> c; }');
+    await assertTarget('', '<>');
+  }
+
+  test_TypeArgumentList2() async {
     // TypeName  TypeArgumentList  TypeName
-    addTestSource('main() { C<C^> c; }');
-    assertTarget('C', '<C>');
-  }
-
-  test_VariableDeclaration_lhs_identifier_after() {
+    await addTestSource('main() { C<C^> c; }');
+    await assertTarget('C', '<C>');
+  }
+
+  test_VariableDeclaration_lhs_identifier_after() async {
     // VariableDeclaration  VariableDeclarationList
-    addTestSource('main() {int b^ = 1;}');
-    assertTarget('b = 1', 'int b = 1');
-  }
-
-  test_VariableDeclaration_lhs_identifier_before() {
+    await addTestSource('main() {int b^ = 1;}');
+    await assertTarget('b = 1', 'int b = 1');
+  }
+
+  test_VariableDeclaration_lhs_identifier_before() async {
     // VariableDeclaration  VariableDeclarationList
-    addTestSource('main() {int ^b = 1;}');
-    assertTarget('b = 1', 'int b = 1');
+    await addTestSource('main() {int ^b = 1;}');
+    await assertTarget('b = 1', 'int b = 1');
   }
 }