Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2859983002: Restore HPKP for facebook.com subdomains and preload [www.]messenger.com for HSTS+HPKP. (Closed)

Created:
3 years, 7 months ago by lgarron
Modified:
3 years, 7 months ago
Reviewers:
CC:
cbentzel+watch_chromium.org, chromium-reviews, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Restore HPKP for facebook.com subdomains and preload [www.]messenger.com for HSTS+HPKP. BUG= TBR=palmer@chromium.org Review-Url: https://codereview.chromium.org/2859983002 . Cr-Commit-Position: refs/heads/master@{#469228} Committed: https://chromium.googlesource.com/chromium/src/+/275c19ecdc32a7d1fc994f77b9972b041a86f7a7

Patch Set 1 #

Patch Set 2 : Restore HPKP for facebook.com and preload [www.]messenger.com for HSTS+HPKP. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M net/http/transport_security_state_static.json View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
lgarron
Committed patchset #2 (id:10001) manually as 275c19ecdc32a7d1fc994f77b9972b041a86f7a7 (presubmit successful).
3 years, 7 months ago (2017-05-04 01:15:22 UTC) #4
findit-for-me
Findit (https://goo.gl/kROfz5) identified this CL at revision 469228 as the culprit for failures in the ...
3 years, 7 months ago (2017-05-04 02:15:59 UTC) #5
lgarron
3 years, 7 months ago (2017-05-04 02:24:16 UTC) #6
Message was sent while issue was closed. 
On 2017/05/04 at 02:15:59, findit-for-me wrote:
> Findit (https://goo.gl/kROfz5) identified this CL at revision 469228 as the
culprit for
> failures in the build cycles as shown on:
>
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

Re #5: Fixed in https://codereview.chromium.org/2861943002

Powered by Google App Engine
This is Rietveld 408576698