Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(886)

Issue 2859963002: Revert of Add more strict DCHECKs around context state. (Closed)

Created:
3 years, 7 months ago by Ken Russell (switch to Gerrit)
Modified:
3 years, 7 months ago
Reviewers:
Zhenyao Mo, jbauman, piman
CC:
chromium-reviews, piman+watch_chromium.org, sunnyps, Geoff Lang, ynovikov
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add more strict DCHECKs around context state. (patchset #1 id:1 of https://codereview.chromium.org/2852353003/ ) Reason for revert: Breaks an optimization needed on some Android devices for performance. Original issue's description: > Add more strict DCHECKs around context state. > > Upon processing commands in the GLES2Decoder, assert that the context > is current. > > Make virtual contexts' definition of "current" more strict. This > required moving a DCHECK inside the base GLContext class. > > These aren't needed, but were useful during recent debugging to > confirm that the bug wasn't in these areas. > > BUG=694359 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2852353003 > Cr-Commit-Position: refs/heads/master@{#469115} > Committed: https://chromium.googlesource.com/chromium/src/+/a21cb49e77bf727d692bbe8dd8eda85a9d089e93 TBR=jbauman@chromium.org,zmo@chromium.org,piman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=694359 Review-Url: https://codereview.chromium.org/2859963002 Cr-Commit-Position: refs/heads/master@{#469185} Committed: https://chromium.googlesource.com/chromium/src/+/84c6c1ca98f4352c0d487e414df24a5e7ef8a4df

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M gpu/command_buffer/service/gl_context_virtual.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gl/gl_context.cc View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Ken Russell (switch to Gerrit)
Created Revert of Add more strict DCHECKs around context state.
3 years, 7 months ago (2017-05-03 23:06:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2859963002/1
3 years, 7 months ago (2017-05-03 23:06:44 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 23:08:05 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/84c6c1ca98f4352c0d487e414df2...

Powered by Google App Engine
This is Rietveld 408576698