Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2859933004: [Android] Change incognito toolbar color back to #505050 (Closed)

Created:
3 years, 7 months ago by Theresa
Modified:
3 years, 7 months ago
Reviewers:
mdjones
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Change incognito toolbar color back to #505050 The toolbar color was changed in https://codereview.chromium.org/2809923003 for Chrome Home. The specified color, #424242, would have required updating tablet tab strip assets to a darker grey, which violated accessibility standards. Reverting to the old color. BUG=716351, 695973 Review-Url: https://codereview.chromium.org/2859933004 Cr-Commit-Position: refs/heads/master@{#469394} Committed: https://chromium.googlesource.com/chromium/src/+/aee22dff8af196f1b8252f69d4cefc7c18893cf0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/res/values/colors.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Theresa
ptal
3 years, 7 months ago (2017-05-04 18:24:12 UTC) #6
mdjones
lgtm
3 years, 7 months ago (2017-05-04 18:31:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2859933004/1
3 years, 7 months ago (2017-05-04 18:33:41 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 18:39:58 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/aee22dff8af196f1b8252f69d4ce...

Powered by Google App Engine
This is Rietveld 408576698