Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2859933002: Use constexpr TaskTraits constructor in extensions. (Closed)

Created:
3 years, 7 months ago by fdoray
Modified:
3 years, 7 months ago
Reviewers:
gab, benwells
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use constexpr TaskTraits constructor in extensions. Use a constexpr constructor that accepts traits in any order instead of the builder pattern to construct TaskTraits in extensions. BUG=713683 R=gab@chromium.org TBR=benwells@chromium.org Review-Url: https://codereview.chromium.org/2859933002 Cr-Commit-Position: refs/heads/master@{#469164} Committed: https://chromium.googlesource.com/chromium/src/+/f79f3091c4a335c5f7d77e7a6d935ee4048d58e0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -29 lines) Patch
M extensions/browser/api/file_handlers/directory_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/file_handlers/mime_util.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/content_hash_fetcher.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M extensions/browser/content_verify_job.cc View 1 chunk +1 line, -3 lines 0 comments Download
M extensions/browser/extension_protocols.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M extensions/browser/image_loader.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M extensions/browser/updater/update_client_config.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M extensions/browser/updater/update_data_provider.cc View 1 chunk +1 line, -2 lines 0 comments Download
M extensions/browser/updater/update_install_shim.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
fdoray
3 years, 7 months ago (2017-05-03 20:22:53 UTC) #1
fdoray
gab@: PTAL The change will then be TBRed to the owner.
3 years, 7 months ago (2017-05-03 20:22:55 UTC) #3
gab
lgtm
3 years, 7 months ago (2017-05-03 20:38:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2859933002/1
3 years, 7 months ago (2017-05-03 20:44:01 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/f79f3091c4a335c5f7d77e7a6d935ee4048d58e0
3 years, 7 months ago (2017-05-03 22:21:18 UTC) #11
benwells
3 years, 7 months ago (2017-05-04 00:27:55 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698