Adds MailtoURLRewriterObserver to MailtoURLRewriter

Adds MailtoURLRewriterObserver to MailtoURLRewriter

Allows an observer to be notified of changes to the default mailto:
handler. This will be needed for implementation of Settings UI.

BUG=711511
Review-Url: https://codereview.chromium.org/2859743002
Cr-Commit-Position: refs/heads/master@{#470620}
Committed: https://chromium.googlesource.com/chromium/src/+/c899e16dcca08a6faabf99f3f283bcc01e6f44f9

[pkl (ping after 24h if needed), 2017-05-08 23:50:20]

Description was changed from

==========
Adds Compose Email Settings UI for deprecating Native App Launcher

BUG=711511
==========

to

==========
Adds MailtoURLRewriterObserver to MailtoURLRewriter

Allows an observer to be notified of changes to the default mailto:
handler. This will be needed for implementation of Settings UI.

BUG=711511
==========

[pkl (ping after 24h if needed), 2017-05-10 01:15:16]

pkl@chromium.org changed reviewers:
+ jif@chromium.org, rohitrao@chromium.org

[pkl (ping after 24h if needed), 2017-05-10 01:15:17]

Adding two APIs for the next CL which adds the Settings UI.

[jif, 2017-05-10 09:32:07]

lgtm with nits

https://codereview.chromium.org/2859743002/diff/180001/ios/chrome/browser/web...
File ios/chrome/browser/web/mailto_url_rewriter.h (right):

https://codereview.chromium.org/2859743002/diff/180001/ios/chrome/browser/web...
ios/chrome/browser/web/mailto_url_rewriter.h:30: @property(nonatomic, assign)
id<MailtoURLRewriterObserver> observer;
use weak instead of assign to avoid the risk of having a dangling pointer.

https://codereview.chromium.org/2859743002/diff/180001/ios/chrome/browser/web...
File ios/chrome/browser/web/mailto_url_rewriter_unittest.mm (right):

https://codereview.chromium.org/2859743002/diff/180001/ios/chrome/browser/web...
ios/chrome/browser/web/mailto_url_rewriter_unittest.mm:160: EXPECT_EQ(2,
[observer changeCount]);
Add final test where |observer| is deallocated and |rewriter| attempts to call
the observer.

[pkl (ping after 24h if needed), 2017-05-10 16:28:06]

jif: Thank you.
rohitrao: PTAL.

https://codereview.chromium.org/2859743002/diff/180001/ios/chrome/browser/web...
File ios/chrome/browser/web/mailto_url_rewriter.h (right):

https://codereview.chromium.org/2859743002/diff/180001/ios/chrome/browser/web...
ios/chrome/browser/web/mailto_url_rewriter.h:30: @property(nonatomic, assign)
id<MailtoURLRewriterObserver> observer;
On 2017/05/10 09:32:07, jif wrote:
> use weak instead of assign to avoid the risk of having a dangling pointer.

Done.

https://codereview.chromium.org/2859743002/diff/180001/ios/chrome/browser/web...
File ios/chrome/browser/web/mailto_url_rewriter_unittest.mm (right):

https://codereview.chromium.org/2859743002/diff/180001/ios/chrome/browser/web...
ios/chrome/browser/web/mailto_url_rewriter_unittest.mm:160: EXPECT_EQ(2,
[observer changeCount]);
On 2017/05/10 09:32:07, jif wrote:
> Add final test where |observer| is deallocated and |rewriter| attempts to call
> the observer.

Done.

[rohitrao (ping after 24h), 2017-05-10 16:41:58]

lgtm

[pkl (ping after 24h if needed), 2017-05-10 16:49:41]

The CQ bit was checked by pkl@chromium.org

[pkl (ping after 24h if needed), 2017-05-10 16:49:41]

The patchset sent to the CQ was uploaded after l-g-t-m from jif@chromium.org
Link to the patchset: https://codereview.chromium.org/2859743002/#ps200001
(title: "make observer weak, and test it.")

[commit-bot: I haz the power, 2017-05-10 16:50:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 17:06:10]

CQ is committing da patch.

Bot data: {"patchset_id": 200001, "attempt_start_ts": 1494434981036790,
"parent_rev": "5130c874ad09faee6fe043cd502a2c1ff07af226", "commit_rev":
"c899e16dcca08a6faabf99f3f283bcc01e6f44f9"}

[commit-bot: I haz the power, 2017-05-10 17:06:18]

Description was changed from

==========
Adds MailtoURLRewriterObserver to MailtoURLRewriter

Allows an observer to be notified of changes to the default mailto:
handler. This will be needed for implementation of Settings UI.

BUG=711511
==========

to

==========
Adds MailtoURLRewriterObserver to MailtoURLRewriter

Allows an observer to be notified of changes to the default mailto:
handler. This will be needed for implementation of Settings UI.

BUG=711511

Review-Url: https://codereview.chromium.org/2859743002
Cr-Commit-Position: refs/heads/master@{#470620}
Committed:
https://chromium.googlesource.com/chromium/src/+/c899e16dcca08a6faabf99f3f283...
==========

[commit-bot: I haz the power, 2017-05-10 17:06:25]

Committed patchset #11 (id:200001) as
https://chromium.googlesource.com/chromium/src/+/c899e16dcca08a6faabf99f3f283...