Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 2859733002: Allow TV turn on without switching inputs (Closed)

Created:
3 years, 7 months ago by almasrymina
Modified:
3 years, 7 months ago
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, gfhuang+watch_chromium.org, halliwell+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow TV turn on without switching inputs BUG= internal b/35766299 TEST= unittests, on device Review-Url: https://codereview.chromium.org/2859733002 Cr-Commit-Position: refs/heads/master@{#468878} Committed: https://chromium.googlesource.com/chromium/src/+/a1bd664cf7bd902f632c6359e63cb06131f78bad

Patch Set 1 #

Patch Set 2 : PS2 #

Patch Set 3 : PS3 #

Total comments: 1

Patch Set 4 : also_switch_inputs->switch_to_cast #

Patch Set 5 : Fix target ref #

Patch Set 6 : Fix target ref #

Patch Set 7 : Fix target ref #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chromecast/public/avsettings.h View 1 2 3 4 5 6 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
almasrymina
3 years, 7 months ago (2017-05-03 01:07:16 UTC) #5
gfhuang
nit https://codereview.chromium.org/2859733002/diff/40001/chromecast/public/avsettings.h File chromecast/public/avsettings.h (right): https://codereview.chromium.org/2859733002/diff/40001/chromecast/public/avsettings.h#newcode171 chromecast/public/avsettings.h:171: virtual bool TurnActive(bool also_switch_inputs) = 0; "switch_to_cast" is ...
3 years, 7 months ago (2017-05-03 01:11:03 UTC) #6
almasrymina
Done. PTAL.
3 years, 7 months ago (2017-05-03 01:14:54 UTC) #7
gfhuang
lgtm
3 years, 7 months ago (2017-05-03 01:15:35 UTC) #8
halliwell
On 2017/05/03 01:15:35, gfhuang wrote: > lgtm lgtm
3 years, 7 months ago (2017-05-03 01:16:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2859733002/60001
3 years, 7 months ago (2017-05-03 01:18:39 UTC) #11
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 7 months ago (2017-05-03 01:18:41 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2859733002/120001
3 years, 7 months ago (2017-05-03 02:44:20 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 02:59:33 UTC) #19
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/a1bd664cf7bd902f632c6359e63c...

Powered by Google App Engine
This is Rietveld 408576698