Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2859693005: Cronet iOS: Move crnet_consumer sample app to Cronet (Closed)

Created:
3 years, 7 months ago by kapishnikov
Modified:
3 years, 7 months ago
Reviewers:
lilyhoughton, mef
CC:
chromium-reviews, cbentzel+watch_chromium.org, ios-reviews_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Cronet iOS: Move crnet_consumer sample app to Cronet We are going to delete CrNet since it is deprecated. Before doing that we should move and preserve the crnet_consumer sample app. BUG=718085 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2859693005 Cr-Commit-Position: refs/heads/master@{#469675} Committed: https://chromium.googlesource.com/chromium/src/+/8b5a164f02e03c1d38e21de063e662328f565197

Patch Set 1 #

Patch Set 2 : Added explicit dependencies #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -309 lines) Patch
M components/cronet/ios/BUILD.gn View 1 1 chunk +6 lines, -0 lines 0 comments Download
A + components/cronet/ios/cronet_consumer/BUILD.gn View 1 2 chunks +9 lines, -9 lines 0 comments Download
A + components/cronet/ios/cronet_consumer/Default.png View Binary file 0 comments Download
A + components/cronet/ios/cronet_consumer/cronet-consumer-Info.plist View 0 chunks +-1 lines, --1 lines 0 comments Download
A components/cronet/ios/cronet_consumer/cronet_consumer_app_delegate.h View 1 chunk +20 lines, -0 lines 0 comments Download
A + components/cronet/ios/cronet_consumer/cronet_consumer_app_delegate.mm View 4 chunks +23 lines, -27 lines 0 comments Download
A components/cronet/ios/cronet_consumer/cronet_consumer_view_controller.h View 1 chunk +14 lines, -0 lines 0 comments Download
A + components/cronet/ios/cronet_consumer/cronet_consumer_view_controller.m View 3 chunks +10 lines, -10 lines 0 comments Download
A + components/cronet/ios/cronet_consumer/main.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M ios/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D ios/crnet/crnet_consumer/BUILD.gn View 1 chunk +0 lines, -30 lines 0 comments Download
D ios/crnet/crnet_consumer/Default.png View Binary file 0 comments Download
D ios/crnet/crnet_consumer/crnet-consumer-Info.plist View 1 chunk +0 lines, -45 lines 0 comments Download
D ios/crnet/crnet_consumer/crnet_consumer_app_delegate.h View 1 chunk +0 lines, -20 lines 0 comments Download
D ios/crnet/crnet_consumer/crnet_consumer_app_delegate.mm View 1 chunk +0 lines, -90 lines 0 comments Download
D ios/crnet/crnet_consumer/crnet_consumer_view_controller.h View 1 chunk +0 lines, -14 lines 0 comments Download
D ios/crnet/crnet_consumer/crnet_consumer_view_controller.m View 1 chunk +0 lines, -46 lines 0 comments Download
D ios/crnet/crnet_consumer/main.mm View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
kapishnikov
Moved crnet_consumer app. PTAL.
3 years, 7 months ago (2017-05-03 21:56:29 UTC) #3
mef
lgtm
3 years, 7 months ago (2017-05-05 15:00:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2859693005/20001
3 years, 7 months ago (2017-05-05 15:19:16 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 16:29:46 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8b5a164f02e03c1d38e21de063e6...

Powered by Google App Engine
This is Rietveld 408576698