runtime/vm/code_patcher_arm64_test.cc - Issue 2859673002: Pass type argument vector to generic functions (if --reify-generic-functions is

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/code_patcher_arm64_test.cc

Issue 2859673002: Pass type argument vector to generic functions (if --reify-generic-functions is (Closed)

Patch Set: fix dartk and sync Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/code_patcher_arm64_test.cc

diff --git a/runtime/vm/code_patcher_arm64_test.cc b/runtime/vm/code_patcher_arm64_test.cc

index 058f81d53db7823662e848515a3115461358089c..2872491aed1fafde7cea868b7322590a496b84f2 100644

--- a/runtime/vm/code_patcher_arm64_test.cc

+++ b/runtime/vm/code_patcher_arm64_test.cc

@@ -34,7 +34,7 @@ ASSEMBLER_TEST_GENERATE(IcDataAccess, assembler) {

const String& target_name = String::Handle(String::New("targetFunction"));

const Array& args_descriptor =

- Array::Handle(ArgumentsDescriptor::New(1, Object::null_array()));

+ Array::Handle(ArgumentsDescriptor::New(0, 1, Object::null_array()));

Vyacheslav Egorov (Google) 2017/05/13 22:20:13 ditto re commenting the meaning of parameters.

regis 2017/05/18 21:02:12 Done.

const ICData& ic_data = ICData::ZoneHandle(

ICData::New(function, target_name, args_descriptor, 15, 1, false));