Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Side by Side Diff: runtime/vm/code_patcher_arm64_test.cc

Issue 2859673002: Pass type argument vector to generic functions (if --reify-generic-functions is (Closed)
Patch Set: fix dartk and sync Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_ARCH_ARM64) 6 #if defined(TARGET_ARCH_ARM64)
7 7
8 #include "vm/assembler.h" 8 #include "vm/assembler.h"
9 #include "vm/code_patcher.h" 9 #include "vm/code_patcher.h"
10 #include "vm/dart_entry.h" 10 #include "vm/dart_entry.h"
(...skipping 16 matching lines...) Expand all
27 const Class& owner_class = Class::Handle(Class::New( 27 const Class& owner_class = Class::Handle(Class::New(
28 Library::Handle(), class_name, script, TokenPosition::kNoSource)); 28 Library::Handle(), class_name, script, TokenPosition::kNoSource));
29 const String& function_name = 29 const String& function_name =
30 String::Handle(Symbols::New(thread, "callerFunction")); 30 String::Handle(Symbols::New(thread, "callerFunction"));
31 const Function& function = Function::Handle(Function::New( 31 const Function& function = Function::Handle(Function::New(
32 function_name, RawFunction::kRegularFunction, true, false, false, false, 32 function_name, RawFunction::kRegularFunction, true, false, false, false,
33 false, owner_class, TokenPosition::kNoSource)); 33 false, owner_class, TokenPosition::kNoSource));
34 34
35 const String& target_name = String::Handle(String::New("targetFunction")); 35 const String& target_name = String::Handle(String::New("targetFunction"));
36 const Array& args_descriptor = 36 const Array& args_descriptor =
37 Array::Handle(ArgumentsDescriptor::New(1, Object::null_array())); 37 Array::Handle(ArgumentsDescriptor::New(0, 1, Object::null_array()));
Vyacheslav Egorov (Google) 2017/05/13 22:20:13 ditto re commenting the meaning of parameters.
regis 2017/05/18 21:02:12 Done.
38 const ICData& ic_data = ICData::ZoneHandle( 38 const ICData& ic_data = ICData::ZoneHandle(
39 ICData::New(function, target_name, args_descriptor, 15, 1, false)); 39 ICData::New(function, target_name, args_descriptor, 15, 1, false));
40 40
41 // Code accessing pp is generated, but not executed. Uninitialized pp is OK. 41 // Code accessing pp is generated, but not executed. Uninitialized pp is OK.
42 __ set_constant_pool_allowed(true); 42 __ set_constant_pool_allowed(true);
43 43
44 __ LoadObject(R5, ic_data); 44 __ LoadObject(R5, ic_data);
45 __ BranchLinkPatchable(*StubCode::OneArgCheckInlineCache_entry()); 45 __ BranchLinkPatchable(*StubCode::OneArgCheckInlineCache_entry());
46 __ ret(); 46 __ ret();
47 } 47 }
48 48
49 49
50 ASSEMBLER_TEST_RUN(IcDataAccess, test) { 50 ASSEMBLER_TEST_RUN(IcDataAccess, test) {
51 uword end = test->payload_start() + test->code().Size(); 51 uword end = test->payload_start() + test->code().Size();
52 uword return_address = end - Instr::kInstrSize; 52 uword return_address = end - Instr::kInstrSize;
53 ICData& ic_data = ICData::Handle(); 53 ICData& ic_data = ICData::Handle();
54 CodePatcher::GetInstanceCallAt(return_address, test->code(), &ic_data); 54 CodePatcher::GetInstanceCallAt(return_address, test->code(), &ic_data);
55 EXPECT_STREQ("targetFunction", 55 EXPECT_STREQ("targetFunction",
56 String::Handle(ic_data.target_name()).ToCString()); 56 String::Handle(ic_data.target_name()).ToCString());
57 EXPECT_EQ(1, ic_data.NumArgsTested()); 57 EXPECT_EQ(1, ic_data.NumArgsTested());
58 EXPECT_EQ(0, ic_data.NumberOfChecks()); 58 EXPECT_EQ(0, ic_data.NumberOfChecks());
59 } 59 }
60 60
61 } // namespace dart 61 } // namespace dart
62 62
63 #endif // defined TARGET_ARCH_ARM64 63 #endif // defined TARGET_ARCH_ARM64
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698