Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2859653002: Remove duplicate service worker tests (Closed)

Created:
3 years, 7 months ago by mike3
Modified:
3 years, 7 months ago
CC:
blink-reviews, chromium-reviews, falken+watch_chromium.org, horo+watch_chromium.org, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, kinuko+serviceworker, michaeln, nhiroki, serviceworker-reviews, shimazu+serviceworker_chromium.org, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove duplicate service worker tests third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-frame-resource.html This test is equivalent to the upstream version. - third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-mixed-content-to-inscope.html - third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-mixed-content-to-outscope.html These tests are roughly equivalent to the upstream versions. Because the upstream versions only differ in the inclusion of additional assertions, the Chromium-specific versions can be safely removed. BUG=688116 R=mek@chromium.org Review-Url: https://codereview.chromium.org/2859653002 Cr-Commit-Position: refs/heads/master@{#469024} Committed: https://chromium.googlesource.com/chromium/src/+/e438b70bdaeaa556a261916ead0e6286f4c077bf

Patch Set 1 #

Messages

Total messages: 7 (3 generated)
mike3
Hi Mek--would you mind taking a look?
3 years, 7 months ago (2017-05-02 21:43:23 UTC) #1
Marijn Kruisselbrink
lgtm
3 years, 7 months ago (2017-05-03 16:12:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2859653002/1
3 years, 7 months ago (2017-05-03 16:19:23 UTC) #4
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 17:35:19 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e438b70bdaeaa556a261916ead0e...

Powered by Google App Engine
This is Rietveld 408576698