Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2859623002: DevTools: Migrate from -webkit-user-modify to contenteditable (Closed)

Created:
3 years, 7 months ago by einbinder
Modified:
3 years, 7 months ago
Reviewers:
dgozman, Xiaocheng
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Migrate from -webkit-user-modify to contenteditable BUG=716649 Review-Url: https://codereview.chromium.org/2859623002 Cr-Commit-Position: refs/heads/master@{#469249} Committed: https://chromium.googlesource.com/chromium/src/+/adda99ec72497e2d3c7ca09f8ab68413a283a966

Patch Set 1 #

Total comments: 6

Patch Set 2 : Add contenteditable on attach #

Messages

Total messages: 13 (5 generated)
einbinder
ptal
3 years, 7 months ago (2017-05-02 20:08:33 UTC) #3
Xiaocheng
Thanks for quick work! https://codereview.chromium.org/2859623002/diff/1/third_party/WebKit/Source/devtools/front_end/elements/elementsTreeOutline.css File third_party/WebKit/Source/devtools/front_end/elements/elementsTreeOutline.css (left): https://codereview.chromium.org/2859623002/diff/1/third_party/WebKit/Source/devtools/front_end/elements/elementsTreeOutline.css#oldcode187 third_party/WebKit/Source/devtools/front_end/elements/elementsTreeOutline.css:187: -webkit-user-select: text; Is this relevant?
3 years, 7 months ago (2017-05-02 21:03:27 UTC) #4
dgozman
https://codereview.chromium.org/2859623002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/InplaceEditor.js File third_party/WebKit/Source/devtools/front_end/ui/InplaceEditor.js (right): https://codereview.chromium.org/2859623002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/InplaceEditor.js#newcode33 third_party/WebKit/Source/devtools/front_end/ui/InplaceEditor.js:33: element.setAttribute('contenteditable', 'plaintext-only'); You probably don't need this. https://codereview.chromium.org/2859623002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js File ...
3 years, 7 months ago (2017-05-02 21:09:21 UTC) #5
einbinder
https://codereview.chromium.org/2859623002/diff/1/third_party/WebKit/Source/devtools/front_end/elements/elementsTreeOutline.css File third_party/WebKit/Source/devtools/front_end/elements/elementsTreeOutline.css (left): https://codereview.chromium.org/2859623002/diff/1/third_party/WebKit/Source/devtools/front_end/elements/elementsTreeOutline.css#oldcode187 third_party/WebKit/Source/devtools/front_end/elements/elementsTreeOutline.css:187: -webkit-user-select: text; On 2017/05/02 at 21:03:26, Xiaocheng wrote: > ...
3 years, 7 months ago (2017-05-04 00:56:25 UTC) #6
dgozman
lgtm
3 years, 7 months ago (2017-05-04 01:04:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2859623002/20001
3 years, 7 months ago (2017-05-04 01:06:42 UTC) #9
Xiaocheng
lgtm as long as -webkit-user-modify is removed.
3 years, 7 months ago (2017-05-04 01:07:01 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 02:39:30 UTC) #13
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/adda99ec72497e2d3c7ca09f8ab6...

Powered by Google App Engine
This is Rietveld 408576698