Disable web payments API on blob: and data: schemes.

Disable web payments API on blob: and data: schemes.

This patch makes PaymentRequest.show() always reject with
NotSupportedError and PaymentRequest.canMakePayments() always return
false on origins that are not either localhost, file://, or
cryptographic scheme.

BUG=717476
Review-Url: https://codereview.chromium.org/2859613002
Cr-Commit-Position: refs/heads/master@{#469991}
Committed: https://chromium.googlesource.com/chromium/src/+/b28f4539b767b634d9257964f04e72b8987910b5

[please use gerrit instead, 2017-05-02 19:53:29]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 19:53:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2017-05-02 19:57:11]

rouslan@chromium.org changed reviewers:
+ meacer@chromium.org

[please use gerrit instead, 2017-05-02 19:57:12]

Mustafa, ptal.

[commit-bot: I haz the power, 2017-05-02 20:42:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 20:42:09]

Dry run: This issue passed the CQ dry run.

[meacer, 2017-05-02 21:21:54]

Thanks for the quick CL! Can you add unit tests for data and blob?

https://codereview.chromium.org/2859613002/diff/1/components/payments/content...
File components/payments/content/payment_request.cc (right):

https://codereview.chromium.org/2859613002/diff/1/components/payments/content...
components/payments/content/payment_request.cc:48: GURL last_committed_url =
delegate_->GetLastCommittedURL();
nit: const GURL

https://codereview.chromium.org/2859613002/diff/1/components/payments/content...
components/payments/content/payment_request.cc:49: if
(!OriginSecurityChecker::IsOriginSecure(last_committed_url)) {
IsOriginSecure returns true for a bunch of schemes including file, filesystem,
about:blank and data. The allowed_origin check is more restrictive than
IsOriginSecure, so it seems we can remove this check?

[please use gerrit instead, 2017-05-03 20:50:06]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 20:50:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2017-05-03 20:53:52]

Ptal patch 2.

https://codereview.chromium.org/2859613002/diff/1/components/payments/content...
File components/payments/content/payment_request.cc (right):

https://codereview.chromium.org/2859613002/diff/1/components/payments/content...
components/payments/content/payment_request.cc:48: GURL last_committed_url =
delegate_->GetLastCommittedURL();
On 2017/05/02 21:21:54, Mustafa Emre Acer wrote:
> nit: const GURL

Done.

https://codereview.chromium.org/2859613002/diff/1/components/payments/content...
components/payments/content/payment_request.cc:49: if
(!OriginSecurityChecker::IsOriginSecure(last_committed_url)) {
On 2017/05/02 21:21:54, Mustafa Emre Acer wrote:
> IsOriginSecure returns true for a bunch of schemes including file, filesystem,
> about:blank and data. The allowed_origin check is more restrictive than
> IsOriginSecure, so it seems we can remove this check?

This check is to verify that the renderer is behaving sanely. The renderer
exposes the PaymentRequest API only in secure context. If this condition is hit,
we should immediately terminate connection to the renderer instead of playing
along as in the allowed_origin check.

[meacer, 2017-05-03 21:08:53]

LGTM, thanks!

https://codereview.chromium.org/2859613002/diff/1/components/payments/content...
File components/payments/content/payment_request.cc (right):

https://codereview.chromium.org/2859613002/diff/1/components/payments/content...
components/payments/content/payment_request.cc:49: if
(!OriginSecurityChecker::IsOriginSecure(last_committed_url)) {
On 2017/05/03 20:53:51, ಠ_ಠ wrote:
> On 2017/05/02 21:21:54, Mustafa Emre Acer wrote:
> > IsOriginSecure returns true for a bunch of schemes including file,
filesystem,
> > about:blank and data. The allowed_origin check is more restrictive than
> > IsOriginSecure, so it seems we can remove this check?
> 
> This check is to verify that the renderer is behaving sanely. The renderer
> exposes the PaymentRequest API only in secure context. If this condition is
hit,
> we should immediately terminate connection to the renderer instead of playing
> along as in the allowed_origin check.

Thanks for the clarification. I didn't notice the OnConnectionTerminated call.

[please use gerrit instead, 2017-05-03 21:11:53]

The CQ bit was unchecked by rouslan@chromium.org

[please use gerrit instead, 2017-05-03 21:11:59]

The CQ bit was checked by rouslan@chromium.org

[commit-bot: I haz the power, 2017-05-03 21:12:15]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 22:25:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 22:25:45]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[please use gerrit instead, 2017-05-04 16:36:35]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 16:37:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 17:27:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 17:27:42]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[please use gerrit instead, 2017-05-05 15:21:03]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 15:21:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 17:30:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 17:30:05]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[please use gerrit instead, 2017-05-08 13:15:26]

The CQ bit was checked by rouslan@chromium.org

[please use gerrit instead, 2017-05-08 13:15:27]

The patchset sent to the CQ was uploaded after l-g-t-m from meacer@chromium.org
Link to the patchset: https://codereview.chromium.org/2859613002/#ps80001
(title: "Fix up Android test")

[commit-bot: I haz the power, 2017-05-08 13:15:39]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 15:41:52]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1494249326634850,
"parent_rev": "363703477995302badde17ad61f435be09b08899", "commit_rev":
"b28f4539b767b634d9257964f04e72b8987910b5"}

[commit-bot: I haz the power, 2017-05-08 15:42:02]

Description was changed from

==========
Disable web payments API on blob: and data: schemes.

This patch makes PaymentRequest.show() always reject with
NotSupportedError and PaymentRequest.canMakePayments() always return
false on origins that are not either localhost, file://, or
cryptographic scheme.

BUG=717476
==========

to

==========
Disable web payments API on blob: and data: schemes.

This patch makes PaymentRequest.show() always reject with
NotSupportedError and PaymentRequest.canMakePayments() always return
false on origins that are not either localhost, file://, or
cryptographic scheme.

BUG=717476

Review-Url: https://codereview.chromium.org/2859613002
Cr-Commit-Position: refs/heads/master@{#469991}
Committed:
https://chromium.googlesource.com/chromium/src/+/b28f4539b767b634d9257964f04e...
==========

[commit-bot: I haz the power, 2017-05-08 15:42:03]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/b28f4539b767b634d9257964f04e...