Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(987)

Issue 2859583003: [Media Router] Updates WATCHLISTS (Closed)

Created:
3 years, 7 months ago by mark a. foltz
Modified:
3 years, 7 months ago
Reviewers:
Wez
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Updates WATCHLISTS. - Removes media-router+watch@ - Adds watchlists for cast_channel, dial, and presentation - Updates watchlist for media_router BUG= Review-Url: https://codereview.chromium.org/2859583003 Cr-Commit-Position: refs/heads/master@{#468903} Committed: https://chromium.googlesource.com/chromium/src/+/57fd7f343a4f67f9d290de1a8a0f5c3f77a9eba7

Patch Set 1 #

Patch Set 2 : Fix presentation #

Total comments: 8

Patch Set 3 : Repond to wez comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -5 lines) Patch
M WATCHLISTS View 1 2 9 chunks +33 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
mark a. foltz
3 years, 7 months ago (2017-05-02 20:58:42 UTC) #2
Wez
LGTM w/ one correction and a few nits. https://codereview.chromium.org/2859583003/diff/20001/WATCHLISTS File WATCHLISTS (right): https://codereview.chromium.org/2859583003/diff/20001/WATCHLISTS#newcode686 WATCHLISTS:686: 'chrome/android/junit/src/org/chromium/chrome/browser/media/router/' ...
3 years, 7 months ago (2017-05-02 23:50:59 UTC) #3
mark a. foltz
https://codereview.chromium.org/2859583003/diff/20001/WATCHLISTS File WATCHLISTS (right): https://codereview.chromium.org/2859583003/diff/20001/WATCHLISTS#newcode686 WATCHLISTS:686: 'chrome/android/junit/src/org/chromium/chrome/browser/media/router/' \ On 2017/05/02 at 23:50:59, Wez wrote: > ...
3 years, 7 months ago (2017-05-03 06:01:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2859583003/40001
3 years, 7 months ago (2017-05-03 06:01:54 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 06:13:15 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/57fd7f343a4f67f9d290de1a8a0f...

Powered by Google App Engine
This is Rietveld 408576698