Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2859563002: Enable browser_tests with Ozone CrOS. (Closed)

Created:
3 years, 7 months ago by kylechar
Modified:
3 years, 6 months ago
Reviewers:
Dirk Pranke, sky
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable browser_tests with Ozone CrOS. Run browser_tests with Ozone CrOS using Ozone headless. Also disable DesktopCaptureApiTest.ChooseDesktopMedia with Ozone CrOS since it fails. BUG=696624, 718512 Review-Url: https://codereview.chromium.org/2859563002 Cr-Commit-Position: refs/heads/master@{#478269} Committed: https://chromium.googlesource.com/chromium/src/+/abe9a0ce490e0858af046e81328929a74b10334b

Patch Set 1 #

Patch Set 2 : Disable failing test. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M chrome/browser/extensions/api/desktop_capture/desktop_capture_apitest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M testing/buildbot/chromium.chromiumos.json View 1 2 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 32 (20 generated)
kylechar
3 years, 7 months ago (2017-05-05 17:01:03 UTC) #4
Dirk Pranke
the change lgtm, but let me double-check capacity before we land this.
3 years, 7 months ago (2017-05-05 17:05:34 UTC) #5
sky
LGTM (but wait for Dirk to verify capacity).
3 years, 7 months ago (2017-05-05 17:43:51 UTC) #6
kylechar
dpranke: Any updates on capacity?
3 years, 7 months ago (2017-05-09 15:02:48 UTC) #8
Dirk Pranke
On 2017/05/09 15:02:48, kylechar wrote: > dpranke: Any updates on capacity? We should be fine, ...
3 years, 7 months ago (2017-05-10 00:09:55 UTC) #9
kylechar
On 2017/05/10 00:09:55, Dirk Pranke wrote: > On 2017/05/09 15:02:48, kylechar wrote: > > dpranke: ...
3 years, 7 months ago (2017-05-11 13:38:18 UTC) #10
Dirk Pranke
On 2017/05/11 13:38:18, kylechar (OOO until 5-29) wrote: > On 2017/05/10 00:09:55, Dirk Pranke wrote: ...
3 years, 7 months ago (2017-05-25 01:56:30 UTC) #11
Dirk Pranke
Sorry for the repeated delays. I think this should be okay to land now.
3 years, 6 months ago (2017-06-07 20:19:29 UTC) #12
kylechar
On 2017/06/07 20:19:29, Dirk Pranke wrote: > Sorry for the repeated delays. I think this ...
3 years, 6 months ago (2017-06-07 20:37:44 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2859563002/40001
3 years, 6 months ago (2017-06-09 14:12:29 UTC) #28
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/abe9a0ce490e0858af046e81328929a74b10334b
3 years, 6 months ago (2017-06-09 14:16:37 UTC) #31
sky
3 years, 6 months ago (2017-06-09 15:18:08 UTC) #32
Message was sent while issue was closed.
Yay! I really look forward to completely getting rid of the X11 code patch
for chromeos!

On Fri, Jun 9, 2017 at 7:16 AM, commit-bot@chromium.org via
codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote:

> Committed patchset #3 (id:40001) as
> https://chromium.googlesource.com/chromium/src/+/
> abe9a0ce490e0858af046e81328929a74b10334b
>
> https://codereview.chromium.org/2859563002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698