|
|
Chromium Code Reviews
DescriptionEnable browser_tests with Ozone CrOS.
Run browser_tests with Ozone CrOS using Ozone headless. Also disable
DesktopCaptureApiTest.ChooseDesktopMedia with Ozone CrOS since it fails.
BUG=696624, 718512
Review-Url: https://codereview.chromium.org/2859563002
Cr-Commit-Position: refs/heads/master@{#478269}
Committed: https://chromium.googlesource.com/chromium/src/+/abe9a0ce490e0858af046e81328929a74b10334b
Patch Set 1 #Patch Set 2 : Disable failing test. #Patch Set 3 : Rebase. #
Messages
Total messages: 32 (20 generated)
Description was changed from ========== Enable browser_tests with Ozone CrOS. Run browser_tests with Ozone CrOS using Ozone headless. BUG= ========== to ========== Enable browser_tests with Ozone CrOS. Run browser_tests with Ozone CrOS using Ozone headless. BUG=696624 ==========
Description was changed from ========== Enable browser_tests with Ozone CrOS. Run browser_tests with Ozone CrOS using Ozone headless. BUG=696624 ========== to ========== Enable browser_tests with Ozone CrOS. Run browser_tests with Ozone CrOS using Ozone headless. Also disable DesktopCaptureApiTest.ChooseDesktopMedia with Ozone CrOS since it fails. BUG=696624 ==========
kylechar@chromium.org changed reviewers: + dpranke@chromium.org, sky@chromium.org
the change lgtm, but let me double-check capacity before we land this.
LGTM (but wait for Dirk to verify capacity).
Description was changed from ========== Enable browser_tests with Ozone CrOS. Run browser_tests with Ozone CrOS using Ozone headless. Also disable DesktopCaptureApiTest.ChooseDesktopMedia with Ozone CrOS since it fails. BUG=696624 ========== to ========== Enable browser_tests with Ozone CrOS. Run browser_tests with Ozone CrOS using Ozone headless. Also disable DesktopCaptureApiTest.ChooseDesktopMedia with Ozone CrOS since it fails. BUG=696624,718512 ==========
dpranke: Any updates on capacity?
On 2017/05/09 15:02:48, kylechar wrote: > dpranke: Any updates on capacity? We should be fine, and I'm going to be adding more capacity tomorrow as well (most likely). I'll land this after the dust settles from the current outage.
On 2017/05/10 00:09:55, Dirk Pranke wrote: > On 2017/05/09 15:02:48, kylechar wrote: > > dpranke: Any updates on capacity? > > We should be fine, and I'm going to be adding more capacity tomorrow as well > (most likely). I'll land this after the dust settles from the current outage. sgtm.
On 2017/05/11 13:38:18, kylechar (OOO until 5-29) wrote: > On 2017/05/10 00:09:55, Dirk Pranke wrote: > > On 2017/05/09 15:02:48, kylechar wrote: > > > dpranke: Any updates on capacity? > > > > We should be fine, and I'm going to be adding more capacity tomorrow as well > > (most likely). I'll land this after the dust settles from the current outage. > > sgtm. Sorry for the delay, the capacity issues have continued and I'm still working through them. Hopefully I'll add this in the next day or two.
Sorry for the repeated delays. I think this should be okay to land now.
On 2017/06/07 20:19:29, Dirk Pranke wrote: > Sorry for the repeated delays. I think this should be okay to land now. Thanks! I'll make sure this still passes and land if so.
The CQ bit was checked by kylechar@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by kylechar@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by kylechar@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by kylechar@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org, sky@chromium.org Link to the patchset: https://codereview.chromium.org/2859563002/#ps40001 (title: "Rebase.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497017532784200,
"parent_rev": "4207742e9a9457d5f374b0dfd3ba2caf24df3362", "commit_rev":
"abe9a0ce490e0858af046e81328929a74b10334b"}
Message was sent while issue was closed.
Description was changed from ========== Enable browser_tests with Ozone CrOS. Run browser_tests with Ozone CrOS using Ozone headless. Also disable DesktopCaptureApiTest.ChooseDesktopMedia with Ozone CrOS since it fails. BUG=696624,718512 ========== to ========== Enable browser_tests with Ozone CrOS. Run browser_tests with Ozone CrOS using Ozone headless. Also disable DesktopCaptureApiTest.ChooseDesktopMedia with Ozone CrOS since it fails. BUG=696624,718512 Review-Url: https://codereview.chromium.org/2859563002 Cr-Commit-Position: refs/heads/master@{#478269} Committed: https://chromium.googlesource.com/chromium/src/+/abe9a0ce490e0858af046e813289... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/abe9a0ce490e0858af046e813289...
Message was sent while issue was closed.
Yay! I really look forward to completely getting rid of the X11 code patch for chromeos! On Fri, Jun 9, 2017 at 7:16 AM, commit-bot@chromium.org via codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote: > Committed patchset #3 (id:40001) as > https://chromium.googlesource.com/chromium/src/+/ > abe9a0ce490e0858af046e81328929a74b10334b > > https://codereview.chromium.org/2859563002/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
