third_party/WebKit/Source/core/frame/FrameView.cpp - Issue 2859543003: Don't run IntersectionObserver lifecycle in frames with dirty layout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2859543003: Don't run IntersectionObserver lifecycle in frames with dirty layout. (Closed)

Patch Set: test expectation Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/FrameView.cpp

diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp

index 542638cc60e7f3ee01de268029f41c582d0ef704..4300359752fe850f6fd464f51751f96332ea3da8 100644

--- a/third_party/WebKit/Source/core/frame/FrameView.cpp

+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp

@@ -4912,7 +4912,7 @@ void FrameView::UpdateViewportIntersectionsForSubtree(

if (!GetFrame().GetDocument()->IsActive())

return;

- if (target_state == DocumentLifecycle::kPaintClean) {

+ if (target_state == DocumentLifecycle::kPaintClean && !NeedsLayout()) {

RecordDeferredLoadingStats();

// Notify javascript IntersectionObservers

if (GetFrame().GetDocument()->GetIntersectionObserverController()) {