Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(829)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2859543003: Don't run IntersectionObserver lifecycle in frames with dirty layout. (Closed)
Patch Set: test expectation Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 4894 matching lines...) Expand 10 before | Expand all | Expand 10 after
4905 void FrameView::UpdateViewportIntersectionsForSubtree( 4905 void FrameView::UpdateViewportIntersectionsForSubtree(
4906 DocumentLifecycle::LifecycleState target_state) { 4906 DocumentLifecycle::LifecycleState target_state) {
4907 // TODO(dcheng): Since FrameViewBase tree updates are deferred, FrameViews 4907 // TODO(dcheng): Since FrameViewBase tree updates are deferred, FrameViews
4908 // might still be in the FrameViewBase hierarchy even though the associated 4908 // might still be in the FrameViewBase hierarchy even though the associated
4909 // Document is already detached. Investigate if this check and a similar check 4909 // Document is already detached. Investigate if this check and a similar check
4910 // in lifecycle updates are still needed when there are no more deferred 4910 // in lifecycle updates are still needed when there are no more deferred
4911 // FrameViewBase updates: https://crbug.com/561683 4911 // FrameViewBase updates: https://crbug.com/561683
4912 if (!GetFrame().GetDocument()->IsActive()) 4912 if (!GetFrame().GetDocument()->IsActive())
4913 return; 4913 return;
4914 4914
4915 if (target_state == DocumentLifecycle::kPaintClean) { 4915 if (target_state == DocumentLifecycle::kPaintClean && !NeedsLayout()) {
4916 RecordDeferredLoadingStats(); 4916 RecordDeferredLoadingStats();
4917 // Notify javascript IntersectionObservers 4917 // Notify javascript IntersectionObservers
4918 if (GetFrame().GetDocument()->GetIntersectionObserverController()) { 4918 if (GetFrame().GetDocument()->GetIntersectionObserverController()) {
4919 GetFrame() 4919 GetFrame()
4920 .GetDocument() 4920 .GetDocument()
4921 ->GetIntersectionObserverController() 4921 ->GetIntersectionObserverController()
4922 ->ComputeTrackedIntersectionObservations(); 4922 ->ComputeTrackedIntersectionObservations();
4923 } 4923 }
4924 } 4924 }
4925 4925
(...skipping 467 matching lines...) Expand 10 before | Expand all | Expand 10 after
5393 void FrameView::SetAnimationHost( 5393 void FrameView::SetAnimationHost(
5394 std::unique_ptr<CompositorAnimationHost> host) { 5394 std::unique_ptr<CompositorAnimationHost> host) {
5395 animation_host_ = std::move(host); 5395 animation_host_ = std::move(host);
5396 } 5396 }
5397 5397
5398 LayoutUnit FrameView::CaretWidth() const { 5398 LayoutUnit FrameView::CaretWidth() const {
5399 return LayoutUnit(GetChromeClient()->WindowToViewportScalar(1)); 5399 return LayoutUnit(GetChromeClient()->WindowToViewportScalar(1));
5400 } 5400 }
5401 5401
5402 } // namespace blink 5402 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698