Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2859543002: Fixed the WallpaperResizer to ensure the image isn't destroyed prematurely. (Closed)

Created:
3 years, 7 months ago by bruthig
Modified:
3 years, 7 months ago
Reviewers:
xdai1
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed the WallpaperResizer to ensure the image isn't destroyed prematurely. This CL ensures the original wallpaper image isn't prematurely destroyed during the resize task. BUG=NONE Review-Url: https://codereview.chromium.org/2859543002 Cr-Commit-Position: refs/heads/master@{#468735} Committed: https://chromium.googlesource.com/chromium/src/+/0e4f55fe3a84ef27f58e16f9071ce4ef9f7bce93

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed patch set 1 comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M components/wallpaper/wallpaper_resizer.cc View 1 2 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
bruthig
xdai@, can you PTAL?
3 years, 7 months ago (2017-05-02 17:52:27 UTC) #4
xdai1
lgtm https://codereview.chromium.org/2859543002/diff/1/components/wallpaper/wallpaper_resizer.cc File components/wallpaper/wallpaper_resizer.cc (right): https://codereview.chromium.org/2859543002/diff/1/components/wallpaper/wallpaper_resizer.cc#newcode27 components/wallpaper/wallpaper_resizer.cc:27: // Resizes |orig_bitmap| to |target_size| using |layout| and ...
3 years, 7 months ago (2017-05-02 18:23:07 UTC) #5
bruthig
Thx! Sending to CQ... https://codereview.chromium.org/2859543002/diff/1/components/wallpaper/wallpaper_resizer.cc File components/wallpaper/wallpaper_resizer.cc (right): https://codereview.chromium.org/2859543002/diff/1/components/wallpaper/wallpaper_resizer.cc#newcode27 components/wallpaper/wallpaper_resizer.cc:27: // Resizes |orig_bitmap| to |target_size| ...
3 years, 7 months ago (2017-05-02 18:29:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2859543002/20001
3 years, 7 months ago (2017-05-02 18:30:46 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 19:12:38 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0e4f55fe3a84ef27f58e16f9071c...

Powered by Google App Engine
This is Rietveld 408576698