Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2859483003: Linux native notifications: Delete notification after sending CloseNotification. (Closed)

Created:
3 years, 7 months ago by Lei Zhang
Modified:
3 years, 7 months ago
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Linux native notifications: Delete notification after sending CloseNotification. Also check the "dbus_id" when handling signals. Fix some nits as well. BUG=676220 Review-Url: https://codereview.chromium.org/2859483003 Cr-Commit-Position: refs/heads/master@{#469148} Committed: https://chromium.googlesource.com/chromium/src/+/8cf43de8a87be9447615ea8bf8965c9979ff18f1

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -41 lines) Patch
M chrome/browser/notifications/notification_platform_bridge_linux.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/notifications/notification_platform_bridge_linux.cc View 10 chunks +51 lines, -38 lines 2 comments Download
M chrome/browser/notifications/notification_platform_bridge_linux_unittest.cc View 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
Lei Zhang
3 years, 7 months ago (2017-05-03 20:56:23 UTC) #6
Tom (Use chromium acct)
lgtm https://codereview.chromium.org/2859483003/diff/1/chrome/browser/notifications/notification_platform_bridge_linux.cc File chrome/browser/notifications/notification_platform_bridge_linux.cc (right): https://codereview.chromium.org/2859483003/diff/1/chrome/browser/notifications/notification_platform_bridge_linux.cc#newcode12 chrome/browser/notifications/notification_platform_bridge_linux.cc:12: #include <vector> out of curiosity, did you do ...
3 years, 7 months ago (2017-05-03 21:42:56 UTC) #7
Lei Zhang
https://codereview.chromium.org/2859483003/diff/1/chrome/browser/notifications/notification_platform_bridge_linux.cc File chrome/browser/notifications/notification_platform_bridge_linux.cc (right): https://codereview.chromium.org/2859483003/diff/1/chrome/browser/notifications/notification_platform_bridge_linux.cc#newcode12 chrome/browser/notifications/notification_platform_bridge_linux.cc:12: #include <vector> On 2017/05/03 21:42:56, Tom Anderson wrote: > ...
3 years, 7 months ago (2017-05-03 21:45:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2859483003/1
3 years, 7 months ago (2017-05-03 21:46:05 UTC) #10
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 7 months ago (2017-05-03 21:46:06 UTC) #12
Tom Anderson
lgtm
3 years, 7 months ago (2017-05-03 21:48:06 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2859483003/1
3 years, 7 months ago (2017-05-03 21:48:44 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 21:58:02 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8cf43de8a87be9447615ea8bf896...

Powered by Google App Engine
This is Rietveld 408576698