Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2964)

Unified Diff: chrome/renderer/page_load_metrics/metrics_render_frame_observer_unittest.cc

Issue 2859393002: Report page load timing information for child frames. (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/page_load_metrics/metrics_render_frame_observer_unittest.cc
diff --git a/chrome/renderer/page_load_metrics/metrics_render_frame_observer_unittest.cc b/chrome/renderer/page_load_metrics/metrics_render_frame_observer_unittest.cc
index 453f15b3740b6264a7220cdc420d5767c5e99eaf..22fdad4ebbb55462b2ea8fc1d21e70ade5674e81 100644
--- a/chrome/renderer/page_load_metrics/metrics_render_frame_observer_unittest.cc
+++ b/chrome/renderer/page_load_metrics/metrics_render_frame_observer_unittest.cc
@@ -41,8 +41,6 @@ class TestMetricsRenderFrameObserver : public MetricsRenderFrameObserver {
mock_timer_ = std::move(timer);
}
- void set_is_main_frame(bool is_main_frame) { is_main_frame_ = is_main_frame; }
-
bool WasFakeTimingConsumed() const { return fake_timing_.IsEmpty(); }
void ExpectPageLoadTiming(const PageLoadTiming& timing) {
@@ -68,13 +66,11 @@ class TestMetricsRenderFrameObserver : public MetricsRenderFrameObserver {
bool ShouldSendMetrics() const override { return true; }
bool HasNoRenderFrame() const override { return false; }
- bool IsMainFrame() const override { return is_main_frame_; }
private:
FakePageTimingMetricsIPCSender fake_timing_ipc_sender_;
mutable PageLoadTiming fake_timing_;
mutable std::unique_ptr<base::Timer> mock_timer_;
- bool is_main_frame_ = true;
};
typedef testing::Test MetricsRenderFrameObserverTest;
@@ -206,24 +202,4 @@ TEST_F(MetricsRenderFrameObserverTest, MultipleNavigations) {
mock_timer2->Fire();
}
-TEST_F(MetricsRenderFrameObserverTest, NoUpdatesFromChildFrames) {
- base::Time nav_start = base::Time::FromDoubleT(10);
-
- TestMetricsRenderFrameObserver observer;
- base::MockTimer* mock_timer = new base::MockTimer(false, false);
- observer.set_mock_timer(base::WrapUnique(mock_timer));
- observer.set_is_main_frame(false);
-
- PageLoadTiming timing;
- timing.navigation_start = nav_start;
- observer.SetFakePageLoadTiming(timing);
- observer.DidCommitProvisionalLoad(true, false);
- ASSERT_FALSE(observer.WasFakeTimingConsumed());
- ASSERT_FALSE(mock_timer->IsRunning());
-
- observer.DidChangePerformanceTiming();
- ASSERT_FALSE(observer.WasFakeTimingConsumed());
- ASSERT_FALSE(mock_timer->IsRunning());
-}
-
} // namespace page_load_metrics

Powered by Google App Engine
This is Rietveld 408576698