Report page load timing information for child frames.

chrome/renderer/page_load_metrics/metrics_render_frame_observer_unittest.cc

 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/page_load_metrics/metrics_render_frame_observer.h"
 
 #include <memory>
 #include <utility>
 
 #include "base/memory/ptr_util.h"
@@ skipping 23 matching lines @@
   // IPC messages get sent.
   bool Send(IPC::Message* message) override {
     return fake_timing_ipc_sender_.Send(message);
   }
 
   void set_mock_timer(std::unique_ptr<base::Timer> timer) {
     ASSERT_EQ(nullptr, mock_timer_);
     mock_timer_ = std::move(timer);
   }
 
-  void set_is_main_frame(bool is_main_frame) { is_main_frame_ = is_main_frame; }
-
   bool WasFakeTimingConsumed() const { return fake_timing_.IsEmpty(); }
 
   void ExpectPageLoadTiming(const PageLoadTiming& timing) {
     SetFakePageLoadTiming(timing);
     fake_timing_ipc_sender_.ExpectPageLoadTiming(timing);
   }
 
   void SetFakePageLoadTiming(const PageLoadTiming& timing) {
     EXPECT_TRUE(fake_timing_.IsEmpty());
     fake_timing_ = timing;
   }
 
   PageLoadTiming GetTiming() const override {
     PageLoadTiming tmp = fake_timing_;
     fake_timing_ = PageLoadTiming();
     return tmp;
   }
 
   void VerifyExpectedTimings() const {
     EXPECT_TRUE(fake_timing_.IsEmpty());
     fake_timing_ipc_sender_.VerifyExpectedTimings();
   }
 
   bool ShouldSendMetrics() const override { return true; }
   bool HasNoRenderFrame() const override { return false; }
-  bool IsMainFrame() const override { return is_main_frame_; }
 
  private:
   FakePageTimingMetricsIPCSender fake_timing_ipc_sender_;
   mutable PageLoadTiming fake_timing_;
   mutable std::unique_ptr<base::Timer> mock_timer_;
-  bool is_main_frame_ = true;
 };
 
 typedef testing::Test MetricsRenderFrameObserverTest;
 
 TEST_F(MetricsRenderFrameObserverTest, NoMetrics) {
   TestMetricsRenderFrameObserver observer;
   base::MockTimer* mock_timer = new base::MockTimer(false, false);
   observer.set_mock_timer(base::WrapUnique(mock_timer));
 
   observer.DidChangePerformanceTiming();
@@ skipping 111 matching lines @@
 
   timing_2.document_timing.first_layout = first_layout_2;
   timing_2.document_timing.dom_content_loaded_event_start = dom_event_2;
   timing_2.document_timing.load_event_start = load_event_2;
   observer.ExpectPageLoadTiming(timing_2);
 
   observer.DidChangePerformanceTiming();
   mock_timer2->Fire();
 }
 
-TEST_F(MetricsRenderFrameObserverTest, NoUpdatesFromChildFrames) {
-  base::Time nav_start = base::Time::FromDoubleT(10);
-
-  TestMetricsRenderFrameObserver observer;
-  base::MockTimer* mock_timer = new base::MockTimer(false, false);
-  observer.set_mock_timer(base::WrapUnique(mock_timer));
-  observer.set_is_main_frame(false);
-
-  PageLoadTiming timing;
-  timing.navigation_start = nav_start;
-  observer.SetFakePageLoadTiming(timing);
-  observer.DidCommitProvisionalLoad(true, false);
-  ASSERT_FALSE(observer.WasFakeTimingConsumed());
-  ASSERT_FALSE(mock_timer->IsRunning());
-
-  observer.DidChangePerformanceTiming();
-  ASSERT_FALSE(observer.WasFakeTimingConsumed());
-  ASSERT_FALSE(mock_timer->IsRunning());
-}
-
 }  // namespace page_load_metrics