chrome/browser/page_load_metrics/page_load_metrics_util.h - Issue 2859393002: Report page load timing information for child frames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_util.h

Issue 2859393002: Report page load timing information for child frames. (Closed)

Patch Set: rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/page_load_metrics/page_load_metrics_util.h

diff --git a/chrome/browser/page_load_metrics/page_load_metrics_util.h b/chrome/browser/page_load_metrics/page_load_metrics_util.h

index b166400fc073fe4b62329a331184ec0df4a94275..a0af192a8b21db5b51127f0313538d4dab7576b6 100644

--- a/chrome/browser/page_load_metrics/page_load_metrics_util.h

+++ b/chrome/browser/page_load_metrics/page_load_metrics_util.h

@@ -126,7 +126,7 @@ base::Optional<base::TimeDelta> OptionalMin(

const base::Optional<base::TimeDelta>& b);

// Whether the given loading behavior was observed in any frame (either the main

-// frame or a child frame).

+// frame or a subframe).

bool DidObserveLoadingBehaviorInAnyFrame(

const page_load_metrics::PageLoadExtraInfo& info,

blink::WebLoadingBehaviorFlag behavior);