chrome/browser/page_load_metrics/page_load_metrics_util.cc - Issue 2859393002: Report page load timing information for child frames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_util.cc

Issue 2859393002: Report page load timing information for child frames. (Closed)

Patch Set: rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/page_load_metrics/page_load_metrics_util.cc

diff --git a/chrome/browser/page_load_metrics/page_load_metrics_util.cc b/chrome/browser/page_load_metrics/page_load_metrics_util.cc

index c46b912d31ac8de7e17b6a7f7ce41ba68f687f81..aba5131a409bdfe4a83b2bb5e1697e9ba252d748 100644

--- a/chrome/browser/page_load_metrics/page_load_metrics_util.cc

+++ b/chrome/browser/page_load_metrics/page_load_metrics_util.cc

@@ -108,7 +108,7 @@ bool DidObserveLoadingBehaviorInAnyFrame(

blink::WebLoadingBehaviorFlag behavior) {

const int all_frame_loading_behavior_flags =

info.main_frame_metadata.behavior_flags |

- info.child_frame_metadata.behavior_flags;

+ info.subframe_metadata.behavior_flags;

return (all_frame_loading_behavior_flags & behavior) != 0;

}