Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Unified Diff: chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc

Issue 2859393002: Report page load timing information for child frames. (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc
index c39d1c97f7248ee6589d6c9adfdd0422dcd32f31..c11c9587767fe76972d17018c67d24d71cfee75b 100644
--- a/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc
@@ -521,28 +521,28 @@ void FromGWSPageLoadMetricsObserver::OnLoadEventStart(
logger_.OnLoadEventStart(timing, extra_info);
}
-void FromGWSPageLoadMetricsObserver::OnFirstPaint(
+void FromGWSPageLoadMetricsObserver::OnFirstPaintInPage(
const page_load_metrics::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& extra_info) {
- logger_.OnFirstPaint(timing, extra_info);
+ logger_.OnFirstPaintInPage(timing, extra_info);
}
-void FromGWSPageLoadMetricsObserver::OnFirstTextPaint(
+void FromGWSPageLoadMetricsObserver::OnFirstTextPaintInPage(
const page_load_metrics::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& extra_info) {
- logger_.OnFirstTextPaint(timing, extra_info);
+ logger_.OnFirstTextPaintInPage(timing, extra_info);
}
-void FromGWSPageLoadMetricsObserver::OnFirstImagePaint(
+void FromGWSPageLoadMetricsObserver::OnFirstImagePaintInPage(
const page_load_metrics::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& extra_info) {
- logger_.OnFirstImagePaint(timing, extra_info);
+ logger_.OnFirstImagePaintInPage(timing, extra_info);
}
-void FromGWSPageLoadMetricsObserver::OnFirstContentfulPaint(
+void FromGWSPageLoadMetricsObserver::OnFirstContentfulPaintInPage(
const page_load_metrics::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& extra_info) {
- logger_.OnFirstContentfulPaint(timing, extra_info);
+ logger_.OnFirstContentfulPaintInPage(timing, extra_info);
}
void FromGWSPageLoadMetricsObserver::OnParseStart(
@@ -692,7 +692,7 @@ void FromGWSPageLoadMetricsLogger::OnLoadEventStart(
}
}
-void FromGWSPageLoadMetricsLogger::OnFirstPaint(
+void FromGWSPageLoadMetricsLogger::OnFirstPaintInPage(
const page_load_metrics::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& extra_info) {
if (ShouldLogForegroundEventAfterCommit(timing.paint_timing.first_paint,
@@ -703,7 +703,7 @@ void FromGWSPageLoadMetricsLogger::OnFirstPaint(
first_paint_triggered_ = true;
}
-void FromGWSPageLoadMetricsLogger::OnFirstTextPaint(
+void FromGWSPageLoadMetricsLogger::OnFirstTextPaintInPage(
const page_load_metrics::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& extra_info) {
if (ShouldLogForegroundEventAfterCommit(timing.paint_timing.first_text_paint,
@@ -713,7 +713,7 @@ void FromGWSPageLoadMetricsLogger::OnFirstTextPaint(
}
}
-void FromGWSPageLoadMetricsLogger::OnFirstImagePaint(
+void FromGWSPageLoadMetricsLogger::OnFirstImagePaintInPage(
const page_load_metrics::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& extra_info) {
if (ShouldLogForegroundEventAfterCommit(timing.paint_timing.first_image_paint,
@@ -723,7 +723,7 @@ void FromGWSPageLoadMetricsLogger::OnFirstImagePaint(
}
}
-void FromGWSPageLoadMetricsLogger::OnFirstContentfulPaint(
+void FromGWSPageLoadMetricsLogger::OnFirstContentfulPaintInPage(
const page_load_metrics::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& extra_info) {
if (ShouldLogForegroundEventAfterCommit(

Powered by Google App Engine
This is Rietveld 408576698