Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Side by Side Diff: chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc

Issue 2859393002: Report page load timing information for child frames. (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_ observer.h" 5 #include "chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_ observer.h"
6 #include <string> 6 #include <string>
7 7
8 #include "base/metrics/histogram_macros.h" 8 #include "base/metrics/histogram_macros.h"
9 #include "base/strings/string_util.h" 9 #include "base/strings/string_util.h"
10 #include "chrome/browser/page_load_metrics/page_load_metrics_util.h" 10 #include "chrome/browser/page_load_metrics/page_load_metrics_util.h"
(...skipping 503 matching lines...) Expand 10 before | Expand all | Expand 10 after
514 const page_load_metrics::PageLoadExtraInfo& extra_info) { 514 const page_load_metrics::PageLoadExtraInfo& extra_info) {
515 logger_.OnDomContentLoadedEventStart(timing, extra_info); 515 logger_.OnDomContentLoadedEventStart(timing, extra_info);
516 } 516 }
517 517
518 void FromGWSPageLoadMetricsObserver::OnLoadEventStart( 518 void FromGWSPageLoadMetricsObserver::OnLoadEventStart(
519 const page_load_metrics::PageLoadTiming& timing, 519 const page_load_metrics::PageLoadTiming& timing,
520 const page_load_metrics::PageLoadExtraInfo& extra_info) { 520 const page_load_metrics::PageLoadExtraInfo& extra_info) {
521 logger_.OnLoadEventStart(timing, extra_info); 521 logger_.OnLoadEventStart(timing, extra_info);
522 } 522 }
523 523
524 void FromGWSPageLoadMetricsObserver::OnFirstPaint( 524 void FromGWSPageLoadMetricsObserver::OnFirstPaintInPage(
525 const page_load_metrics::PageLoadTiming& timing, 525 const page_load_metrics::PageLoadTiming& timing,
526 const page_load_metrics::PageLoadExtraInfo& extra_info) { 526 const page_load_metrics::PageLoadExtraInfo& extra_info) {
527 logger_.OnFirstPaint(timing, extra_info); 527 logger_.OnFirstPaintInPage(timing, extra_info);
528 } 528 }
529 529
530 void FromGWSPageLoadMetricsObserver::OnFirstTextPaint( 530 void FromGWSPageLoadMetricsObserver::OnFirstTextPaintInPage(
531 const page_load_metrics::PageLoadTiming& timing, 531 const page_load_metrics::PageLoadTiming& timing,
532 const page_load_metrics::PageLoadExtraInfo& extra_info) { 532 const page_load_metrics::PageLoadExtraInfo& extra_info) {
533 logger_.OnFirstTextPaint(timing, extra_info); 533 logger_.OnFirstTextPaintInPage(timing, extra_info);
534 } 534 }
535 535
536 void FromGWSPageLoadMetricsObserver::OnFirstImagePaint( 536 void FromGWSPageLoadMetricsObserver::OnFirstImagePaintInPage(
537 const page_load_metrics::PageLoadTiming& timing, 537 const page_load_metrics::PageLoadTiming& timing,
538 const page_load_metrics::PageLoadExtraInfo& extra_info) { 538 const page_load_metrics::PageLoadExtraInfo& extra_info) {
539 logger_.OnFirstImagePaint(timing, extra_info); 539 logger_.OnFirstImagePaintInPage(timing, extra_info);
540 } 540 }
541 541
542 void FromGWSPageLoadMetricsObserver::OnFirstContentfulPaint( 542 void FromGWSPageLoadMetricsObserver::OnFirstContentfulPaintInPage(
543 const page_load_metrics::PageLoadTiming& timing, 543 const page_load_metrics::PageLoadTiming& timing,
544 const page_load_metrics::PageLoadExtraInfo& extra_info) { 544 const page_load_metrics::PageLoadExtraInfo& extra_info) {
545 logger_.OnFirstContentfulPaint(timing, extra_info); 545 logger_.OnFirstContentfulPaintInPage(timing, extra_info);
546 } 546 }
547 547
548 void FromGWSPageLoadMetricsObserver::OnParseStart( 548 void FromGWSPageLoadMetricsObserver::OnParseStart(
549 const page_load_metrics::PageLoadTiming& timing, 549 const page_load_metrics::PageLoadTiming& timing,
550 const page_load_metrics::PageLoadExtraInfo& extra_info) { 550 const page_load_metrics::PageLoadExtraInfo& extra_info) {
551 logger_.OnParseStart(timing, extra_info); 551 logger_.OnParseStart(timing, extra_info);
552 } 552 }
553 553
554 void FromGWSPageLoadMetricsObserver::OnParseStop( 554 void FromGWSPageLoadMetricsObserver::OnParseStop(
555 const page_load_metrics::PageLoadTiming& timing, 555 const page_load_metrics::PageLoadTiming& timing,
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
685 void FromGWSPageLoadMetricsLogger::OnLoadEventStart( 685 void FromGWSPageLoadMetricsLogger::OnLoadEventStart(
686 const page_load_metrics::PageLoadTiming& timing, 686 const page_load_metrics::PageLoadTiming& timing,
687 const page_load_metrics::PageLoadExtraInfo& extra_info) { 687 const page_load_metrics::PageLoadExtraInfo& extra_info) {
688 if (ShouldLogForegroundEventAfterCommit( 688 if (ShouldLogForegroundEventAfterCommit(
689 timing.document_timing.load_event_start, extra_info)) { 689 timing.document_timing.load_event_start, extra_info)) {
690 PAGE_LOAD_HISTOGRAM(internal::kHistogramFromGWSLoad, 690 PAGE_LOAD_HISTOGRAM(internal::kHistogramFromGWSLoad,
691 timing.document_timing.load_event_start.value()); 691 timing.document_timing.load_event_start.value());
692 } 692 }
693 } 693 }
694 694
695 void FromGWSPageLoadMetricsLogger::OnFirstPaint( 695 void FromGWSPageLoadMetricsLogger::OnFirstPaintInPage(
696 const page_load_metrics::PageLoadTiming& timing, 696 const page_load_metrics::PageLoadTiming& timing,
697 const page_load_metrics::PageLoadExtraInfo& extra_info) { 697 const page_load_metrics::PageLoadExtraInfo& extra_info) {
698 if (ShouldLogForegroundEventAfterCommit(timing.paint_timing.first_paint, 698 if (ShouldLogForegroundEventAfterCommit(timing.paint_timing.first_paint,
699 extra_info)) { 699 extra_info)) {
700 PAGE_LOAD_HISTOGRAM(internal::kHistogramFromGWSFirstPaint, 700 PAGE_LOAD_HISTOGRAM(internal::kHistogramFromGWSFirstPaint,
701 timing.paint_timing.first_paint.value()); 701 timing.paint_timing.first_paint.value());
702 } 702 }
703 first_paint_triggered_ = true; 703 first_paint_triggered_ = true;
704 } 704 }
705 705
706 void FromGWSPageLoadMetricsLogger::OnFirstTextPaint( 706 void FromGWSPageLoadMetricsLogger::OnFirstTextPaintInPage(
707 const page_load_metrics::PageLoadTiming& timing, 707 const page_load_metrics::PageLoadTiming& timing,
708 const page_load_metrics::PageLoadExtraInfo& extra_info) { 708 const page_load_metrics::PageLoadExtraInfo& extra_info) {
709 if (ShouldLogForegroundEventAfterCommit(timing.paint_timing.first_text_paint, 709 if (ShouldLogForegroundEventAfterCommit(timing.paint_timing.first_text_paint,
710 extra_info)) { 710 extra_info)) {
711 PAGE_LOAD_HISTOGRAM(internal::kHistogramFromGWSFirstTextPaint, 711 PAGE_LOAD_HISTOGRAM(internal::kHistogramFromGWSFirstTextPaint,
712 timing.paint_timing.first_text_paint.value()); 712 timing.paint_timing.first_text_paint.value());
713 } 713 }
714 } 714 }
715 715
716 void FromGWSPageLoadMetricsLogger::OnFirstImagePaint( 716 void FromGWSPageLoadMetricsLogger::OnFirstImagePaintInPage(
717 const page_load_metrics::PageLoadTiming& timing, 717 const page_load_metrics::PageLoadTiming& timing,
718 const page_load_metrics::PageLoadExtraInfo& extra_info) { 718 const page_load_metrics::PageLoadExtraInfo& extra_info) {
719 if (ShouldLogForegroundEventAfterCommit(timing.paint_timing.first_image_paint, 719 if (ShouldLogForegroundEventAfterCommit(timing.paint_timing.first_image_paint,
720 extra_info)) { 720 extra_info)) {
721 PAGE_LOAD_HISTOGRAM(internal::kHistogramFromGWSFirstImagePaint, 721 PAGE_LOAD_HISTOGRAM(internal::kHistogramFromGWSFirstImagePaint,
722 timing.paint_timing.first_image_paint.value()); 722 timing.paint_timing.first_image_paint.value());
723 } 723 }
724 } 724 }
725 725
726 void FromGWSPageLoadMetricsLogger::OnFirstContentfulPaint( 726 void FromGWSPageLoadMetricsLogger::OnFirstContentfulPaintInPage(
727 const page_load_metrics::PageLoadTiming& timing, 727 const page_load_metrics::PageLoadTiming& timing,
728 const page_load_metrics::PageLoadExtraInfo& extra_info) { 728 const page_load_metrics::PageLoadExtraInfo& extra_info) {
729 if (ShouldLogForegroundEventAfterCommit( 729 if (ShouldLogForegroundEventAfterCommit(
730 timing.paint_timing.first_contentful_paint, extra_info)) { 730 timing.paint_timing.first_contentful_paint, extra_info)) {
731 PAGE_LOAD_HISTOGRAM(internal::kHistogramFromGWSFirstContentfulPaint, 731 PAGE_LOAD_HISTOGRAM(internal::kHistogramFromGWSFirstContentfulPaint,
732 timing.paint_timing.first_contentful_paint.value()); 732 timing.paint_timing.first_contentful_paint.value());
733 733
734 // If we have a foreground paint, we should have a foreground parse start, 734 // If we have a foreground paint, we should have a foreground parse start,
735 // since paints can't happen until after parsing starts. 735 // since paints can't happen until after parsing starts.
736 DCHECK(WasStartedInForegroundOptionalEventInForeground( 736 DCHECK(WasStartedInForegroundOptionalEventInForeground(
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
770 first_user_interaction_after_paint_ = 770 first_user_interaction_after_paint_ =
771 base::TimeTicks::Now() - navigation_start_; 771 base::TimeTicks::Now() - navigation_start_;
772 } 772 }
773 } 773 }
774 774
775 void FromGWSPageLoadMetricsLogger::FlushMetricsOnAppEnterBackground( 775 void FromGWSPageLoadMetricsLogger::FlushMetricsOnAppEnterBackground(
776 const page_load_metrics::PageLoadTiming& timing, 776 const page_load_metrics::PageLoadTiming& timing,
777 const page_load_metrics::PageLoadExtraInfo& extra_info) { 777 const page_load_metrics::PageLoadExtraInfo& extra_info) {
778 LogForegroundDurations(timing, extra_info, base::TimeTicks::Now()); 778 LogForegroundDurations(timing, extra_info, base::TimeTicks::Now());
779 } 779 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698