Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc

Issue 2859393002: Report page load timing information for child frames. (Closed)
Patch Set: cleanup Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc
diff --git a/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc b/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc
index 059653cbaf9ebc27469efbaf6d40328aa3d5bb12..679ba6e769e853845e3b4164b4b3f4a26a48cb5a 100644
--- a/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc
+++ b/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc
@@ -38,9 +38,7 @@ MetricsRenderFrameObserver::MetricsRenderFrameObserver(
MetricsRenderFrameObserver::~MetricsRenderFrameObserver() {}
void MetricsRenderFrameObserver::DidChangePerformanceTiming() {
- // Only track timing metrics for main frames.
- if (IsMainFrame())
- SendMetrics();
+ SendMetrics();
}
void MetricsRenderFrameObserver::DidObserveLoadingBehavior(
@@ -72,14 +70,8 @@ void MetricsRenderFrameObserver::DidCommitProvisionalLoad(
// non-null, we will send metrics for the current page at some later time, as
// those metrics become available.
if (ShouldSendMetrics()) {
- PageLoadTiming timing;
- if (IsMainFrame()) {
- // Only populate PageLoadTiming for the main frame.
- timing = GetTiming();
- DCHECK(!timing.navigation_start.is_null());
- }
- page_timing_metrics_sender_.reset(
- new PageTimingMetricsSender(this, routing_id(), CreateTimer(), timing));
+ page_timing_metrics_sender_.reset(new PageTimingMetricsSender(
+ this, routing_id(), CreateTimer(), GetTiming()));
jkarlin 2017/05/08 13:00:41 page_timing_metrics_sender_ = base::MakeUnique<Pag
Bryan McQuade 2017/05/08 15:26:32 Done
}
}
@@ -185,8 +177,4 @@ void MetricsRenderFrameObserver::OnDestruct() {
delete this;
}
-bool MetricsRenderFrameObserver::IsMainFrame() const {
- return render_frame()->IsMainFrame();
-}
-
} // namespace page_load_metrics

Powered by Google App Engine
This is Rietveld 408576698