Report page load timing information for child frames.

chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/page_load_metrics/metrics_render_frame_observer.h"
 
 #include <string>
 
 #include "base/memory/ptr_util.h"
 #include "base/time/time.h"
@@ skipping 20 matching lines @@
 
 }  //  namespace
 
 MetricsRenderFrameObserver::MetricsRenderFrameObserver(
     content::RenderFrame* render_frame)
     : content::RenderFrameObserver(render_frame) {}
 
 MetricsRenderFrameObserver::~MetricsRenderFrameObserver() {}
 
 void MetricsRenderFrameObserver::DidChangePerformanceTiming() {
-  // Only track timing metrics for main frames.
-  if (IsMainFrame())
-    SendMetrics();
+  SendMetrics();
 }
 
 void MetricsRenderFrameObserver::DidObserveLoadingBehavior(
     blink::WebLoadingBehaviorFlag behavior) {
   if (page_timing_metrics_sender_)
     page_timing_metrics_sender_->DidObserveLoadingBehavior(behavior);
 }
 
 void MetricsRenderFrameObserver::FrameDetached() {
   page_timing_metrics_sender_.reset();
@@ skipping 11 matching lines @@
     return;
 
   // Make sure to release the sender for a previous navigation, if we have one.
   page_timing_metrics_sender_.reset();
 
   // We only create a PageTimingMetricsSender if the page meets the criteria for
   // sending and recording metrics. Once page_timing_metrics_sender_ is
   // non-null, we will send metrics for the current page at some later time, as
   // those metrics become available.
   if (ShouldSendMetrics()) {
-    PageLoadTiming timing;
-    if (IsMainFrame()) {
-      // Only populate PageLoadTiming for the main frame.
-      timing = GetTiming();
-      DCHECK(!timing.navigation_start.is_null());
-    }
-    page_timing_metrics_sender_.reset(
-        new PageTimingMetricsSender(this, routing_id(), CreateTimer(), timing));
+    page_timing_metrics_sender_.reset(new PageTimingMetricsSender(
+        this, routing_id(), CreateTimer(), GetTiming()));

[jkarlin, 2017/05/08 13:00:41]

page_timing_metrics_sender_ = base::MakeUnique<PageTimingMetricsSender>(this,
routing_id(), CreateTimer(), GetTiming());

[Bryan McQuade, 2017/05/08 15:26:32]

Done

   }
 }
 
 void MetricsRenderFrameObserver::SendMetrics() {
   if (!page_timing_metrics_sender_)
     return;
   if (HasNoRenderFrame())
     return;
   PageLoadTiming timing(GetTiming());
   page_timing_metrics_sender_->Send(timing);
@@ skipping 85 matching lines @@
 bool MetricsRenderFrameObserver::HasNoRenderFrame() const {
   bool no_frame = !render_frame() || !render_frame()->GetWebFrame();
   DCHECK(!no_frame);
   return no_frame;
 }
 
 void MetricsRenderFrameObserver::OnDestruct() {
   delete this;
 }
 
-bool MetricsRenderFrameObserver::IsMainFrame() const {
-  return render_frame()->IsMainFrame();
-}
-
 }  // namespace page_load_metrics