Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2859323002: Remove Trusty sysroot (Closed)

Created:
3 years, 7 months ago by Tom (Use chromium acct)
Modified:
3 years, 7 months ago
Reviewers:
Lei Zhang, Sam Clegg
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Trusty sysroot The Trusty sysroot was only used for building Chromium for ARM. Since this is now the responsibility of the Jessie sysroot, the Trusty sysroot can be removed. R=thestig@chromium.org,sbc@chromium.org Review-Url: https://codereview.chromium.org/2859323002 Cr-Commit-Position: refs/heads/master@{#469565} Committed: https://chromium.googlesource.com/chromium/src/+/19e8945a7c43de08fdd74f31241d67c327289e0d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -371 lines) Patch
M build/linux/sysroot_scripts/merge-package-lists.py View 1 chunk +2 lines, -2 lines 0 comments Download
D build/linux/sysroot_scripts/packagelist.trusty.arm View 1 chunk +0 lines, -163 lines 0 comments Download
M build/linux/sysroot_scripts/sysroot-creator.sh View 2 chunks +4 lines, -4 lines 0 comments Download
D build/linux/sysroot_scripts/sysroot-creator-trusty.sh View 1 chunk +0 lines, -196 lines 0 comments Download
M build/linux/sysroot_scripts/sysroots.json View 1 chunk +0 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (11 generated)
Tom (Use chromium acct)
reviewers ptal
3 years, 7 months ago (2017-05-04 23:16:32 UTC) #1
Lei Zhang
lgtm There are no bots that use the trusty_arm sysroot, right?
3 years, 7 months ago (2017-05-04 23:18:22 UTC) #2
Sam Clegg
lgtm
3 years, 7 months ago (2017-05-04 23:30:06 UTC) #3
Tom (Use chromium acct)
On 2017/05/04 23:18:22, Lei Zhang wrote: > lgtm > > There are no bots that ...
3 years, 7 months ago (2017-05-04 23:51:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2859323002/1
3 years, 7 months ago (2017-05-05 01:26:04 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 01:31:00 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/19e8945a7c43de08fdd74f31241d...

Powered by Google App Engine
This is Rietveld 408576698