android: Fix display size under multiwindow

android: Fix display size under multiwindow

Android did not update the docs when multiwindow was implemented. But
essentially Display.getSize/getMetrics no longer refer to the Display
size, but to the window size, in order to be backwards compatible.

Fix and simply DisplayAndroid. Remove the distinction between "size"
and "physical size" by removing the concept of "physical" size. Always
just get the most correct size available.

Went through all use cases getSize. They all either don't care, or
was already trying to get the most correct value.

Review-Url: https://codereview.chromium.org/2859313002
Cr-Commit-Position: refs/heads/master@{#469554}
Committed: https://chromium.googlesource.com/chromium/src/+/799c3a19b81b7ae194e4740defb95656f6de7034

[boliu, 2017-05-04 23:03:43]

The CQ bit was checked by boliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 23:04:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[boliu, 2017-05-04 23:25:43]

boliu@chromium.org changed reviewers:
+ mthiesse@chromium.org, tedchoc@chromium.org

[boliu, 2017-05-04 23:25:44]

tedchoc: look over the whole thing. Unfortunately most call sites did not
require any change, so don't show up in code review. Need to search for
getDisplayWidth/Height instead. In particular, I looked into
AutofillKeyboardAccessory a bit, but I think using the display size is correct
and it's currently broken for multiwindow (looking at screenshots in
crbug.com/428087)

mthiesse: VrShellImpl

[mthiesse, 2017-05-04 23:40:02]

VrShellImpl lgtm

[commit-bot: I haz the power, 2017-05-05 00:11:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 00:11:17]

Dry run: This issue passed the CQ dry run.

[Ted C, 2017-05-05 00:41:14]

lgtm

[boliu, 2017-05-05 00:45:05]

The CQ bit was checked by boliu@chromium.org

[commit-bot: I haz the power, 2017-05-05 00:45:50]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 00:51:29]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493945105816950, "parent_rev":
"783900c29c6242e65191a8951e12ce45c739571e", "commit_rev":
"799c3a19b81b7ae194e4740defb95656f6de7034"}

[commit-bot: I haz the power, 2017-05-05 00:51:43]

Description was changed from

==========
android: Fix display size under multiwindow

Android did not update the docs when multiwindow was implemented. But
essentially Display.getSize/getMetrics no longer refer to the Display
size, but to the window size, in order to be backwards compatible.

Fix and simply DisplayAndroid. Remove the distinction between "size"
and "physical size" by removing the concept of "physical" size. Always
just get the most correct size available.

Went through all use cases getSize. They all either don't care, or
was already trying to get the most correct value.
==========

to

==========
android: Fix display size under multiwindow

Android did not update the docs when multiwindow was implemented. But
essentially Display.getSize/getMetrics no longer refer to the Display
size, but to the window size, in order to be backwards compatible.

Fix and simply DisplayAndroid. Remove the distinction between "size"
and "physical size" by removing the concept of "physical" size. Always
just get the most correct size available.

Went through all use cases getSize. They all either don't care, or
was already trying to get the most correct value.

Review-Url: https://codereview.chromium.org/2859313002
Cr-Commit-Position: refs/heads/master@{#469554}
Committed:
https://chromium.googlesource.com/chromium/src/+/799c3a19b81b7ae194e4740defb9...
==========

[commit-bot: I haz the power, 2017-05-05 00:51:44]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/799c3a19b81b7ae194e4740defb9...