Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2859303002: Work-around ASAN problem in profiler (Closed)

Created:
3 years, 7 months ago by rjkroege
Modified:
3 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, danakj+watch_chromium.org, mac-reviews_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Work-around ASAN problem in profiler ASAN wraps the kernel dylib on mac. Special case this to avoid tripping a DCHECK. BUG=718628 TBR=avi@chromium.org Review-Url: https://codereview.chromium.org/2859303002 Cr-Commit-Position: refs/heads/master@{#469515} Committed: https://chromium.googlesource.com/chromium/src/+/6fc72beca8ade08e0dff7ef5bb555f6fee9656fd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M base/profiler/native_stack_sampler_mac.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2859303002/1
3 years, 7 months ago (2017-05-04 22:43:14 UTC) #2
Avi (use Gerrit)
lgtm
3 years, 7 months ago (2017-05-04 23:18:55 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 23:25:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6fc72beca8ade08e0dff7ef5bb55...

Powered by Google App Engine
This is Rietveld 408576698