Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2859293003: media: Restrict ProtectedMediaIdentifier permission to secure origins (Closed)

Created:
3 years, 7 months ago by xhwang
Modified:
3 years, 7 months ago
Reviewers:
*jrummell, ddorwin
CC:
chromium-reviews, mlamouri+watch-permissions_chromium.org, chfremer+watch_chromium.org, raymes+watch_chromium.org, feature-media-reviews_chromium.org, ddorwin
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Restrict ProtectedMediaIdentifier permission to secure origins Currently EME is restricted to secure origins (see BUG). However, it's possible that the renderer process is compromised and bypasses this restriction. This CL restricts the ProtectedMediaIdentifier permission to secure origin as well to add another layer of protection. Origins whitelisted by the --unsafely-treat-insecure-origin-as-secure flag will always be treated as "secure", and as such will not be affected by this change. BUG=672605 Review-Url: https://codereview.chromium.org/2859293003 Cr-Commit-Position: refs/heads/master@{#469866} Committed: https://chromium.googlesource.com/chromium/src/+/fb4dd15c290ffa283c157f42f4d5abae97c3193d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M chrome/browser/media/protected_media_identifier_permission_context.cc View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
xhwang
jrummell: PTAL ddorwin: FYI
3 years, 7 months ago (2017-05-04 21:50:30 UTC) #5
ddorwin
lgtm
3 years, 7 months ago (2017-05-04 21:55:16 UTC) #7
jrummell
lgtm
3 years, 7 months ago (2017-05-05 18:09:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2859293003/1
3 years, 7 months ago (2017-05-06 05:20:18 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-06 19:07:29 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fb4dd15c290ffa283c157f42f4d5...

Powered by Google App Engine
This is Rietveld 408576698