DescriptionRevert of Support base::test::ScopedTaskEnvironment and content::TestBrowserThreadBundle in the same scope. (patchset #7 id:110001 of https://codereview.chromium.org/2860533002/ )
Reason for revert:
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20trunk fails
failures:
TestBrowserThreadBundleTest.MultipleTestBrowserThreadBundle
TestBrowserThreadBundleTest.MessageLoopTypeMismatch
Original issue's description:
> Support base::test::ScopedTaskEnvironment and content::TestBrowserThreadBundle in the same scope.
>
> A test suite that depends on a test suite base that provides a
> base::test::ScopedTaskEnvironment may need browser threads. Currently,
> the test suite cannot use content::TestBrowserThreadBundle to get
> these browser threads because base::test::ScopedTaskEnvironment and
> content::TestBrowserThreadBundle both set the main MessageLoop and
> the TaskScheduler. With this CL, content::TestBrowserThreadBundle
> doesn't set the main MessageLoop and the TaskScheduler if they
> already exist.
>
> E.g.
> Test suite: ToolbarActionViewUnitTest
> Needs BrowserThreads
> Base test suite: views::ViewsTestBase
> Provides a ScopedTaskEnvironment
>
> BUG=
>
> Review-Url: https://codereview.chromium.org/2860533002
> Cr-Commit-Position: refs/heads/master@{#469304}
> Committed: https://chromium.googlesource.com/chromium/src/+/ba0dacfc73d208fc779907890bc94dbd09ef1aad
TBR=gab@chromium.org,robliao@chromium.org,sky@chromium.org,fdoray@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review-Url: https://codereview.chromium.org/2859283002
Cr-Commit-Position: refs/heads/master@{#469416}
Committed: https://chromium.googlesource.com/chromium/src/+/fe9e5c8eb8b0f7673827718ed72050c0d0b65147
Patch Set 1 #
Messages
Total messages: 3 (2 generated)
|