Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(11)

Issue 2859273004: Use ScopedTaskEnvironment instead of MessageLoop in media/capture/ unit tests (Closed)

Created:
2 years ago by Chandan
Modified:
2 years ago
Reviewers:
fdoray, chfremer
CC:
chromium-reviews, posciak+watch_chromium.org, chfremer+watch_chromium.org, feature-media-reviews_chromium.org, xjz+watch_chromium.org, mfoltz+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ScopedTaskEnvironment instead of MessageLoop in media/capture/ unit tests ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and base/task_scheduler/post_task.h within its scope. It should be instantiated in every unit test that uses either of these APIs (i.e. no test should instantiate a MessageLoop directly). Motivation for ScopedTaskEnvironment can be found in: https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3Pkk/edit BUG=708584 Review-Url: https://codereview.chromium.org/2859273004 Cr-Commit-Position: refs/heads/master@{#469691} Committed: https://chromium.googlesource.com/chromium/src/+/5742c3808b947b73c4e279c2f753e59e284a1910

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M media/capture/video/fake_video_capture_device_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M media/capture/video/linux/v4l2_capture_delegate_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M media/capture/video/video_capture_device_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Chandan
PTAL. Thank you.
2 years ago (2017-05-05 14:36:49 UTC) #6
chfremer
lgtm
2 years ago (2017-05-05 16:34:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2859273004/1
2 years ago (2017-05-05 17:03:10 UTC) #9
commit-bot: I haz the power
2 years ago (2017-05-05 17:11:15 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5742c3808b947b73c4e279c2f753...

Powered by Google App Engine
This is Rietveld 408576698