Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 2859273002: [DevTools] Do not talk to inspector overlay from outside (Closed)

Created:
3 years, 7 months ago by dgozman
Modified:
3 years, 7 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, mlamouri+watch-blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, dcheng, devtools-reviews_chromium.org, blink-reviews, kinuko+watch, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Do not talk to inspector overlay from outside Mediated three methods through WebDevToolsAgentImpl, which encapsulates overlay logic inside. This will avoid changes outside of WebDevToolsAgentImpl in case of multiclient. BUG=590878 Review-Url: https://codereview.chromium.org/2859273002 Cr-Commit-Position: refs/heads/master@{#469572} Committed: https://chromium.googlesource.com/chromium/src/+/2e20b0107a76f5a7ff3fd0dac5b0a1a0c4a1fe7b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -52 lines) Patch
M third_party/WebKit/Source/web/InspectorOverlayAgent.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlayAgent.cpp View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.h View 3 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 1 chunk +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.h View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp View 4 chunks +7 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.h View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 5 chunks +6 lines, -21 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
dgozman
Take a look please.
3 years, 7 months ago (2017-05-04 17:57:51 UTC) #2
pfeldman
lgtm
3 years, 7 months ago (2017-05-04 22:25:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2859273002/1
3 years, 7 months ago (2017-05-05 00:16:29 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 02:07:38 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2e20b0107a76f5a7ff3fd0dac5b0...

Powered by Google App Engine
This is Rietveld 408576698