ThumbnailTabHelper: Capture thumbnail when page load finishes

ThumbnailTabHelper: Capture thumbnail when page load finishes

Hidden behind a flag.

BUG=718413
Review-Url: https://codereview.chromium.org/2859263002
Cr-Commit-Position: refs/heads/master@{#469943}
Committed: https://chromium.googlesource.com/chromium/src/+/32d2e42a7df134836e116dcadd1ad70cd489d1c3

[Marc Treib, 2017-05-05 10:17:48]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 10:18:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 11:01:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 11:01:21]

Dry run: This issue passed the CQ dry run.

[Marc Treib, 2017-05-05 11:10:22]

treib@chromium.org changed reviewers:
+ thestig@chromium.org

[Marc Treib, 2017-05-05 11:10:23]

PTAL!

[Unfortunately, c/b/thumbnails/ doesn't have any more specific owners, and it
seems you reviewed the last non-trivial change here a while back
(https://codereview.chromium.org/1461463002). If you know anyone better suited
for reviewing this, please let me know, and maybe we can get a proper owners
file set up.]

[Lei Zhang, 2017-05-05 21:32:01]

lgtm

Ya, I don't know who would be a good owner here either.

https://codereview.chromium.org/2859263002/diff/20001/chrome/browser/thumbnai...
File chrome/browser/thumbnails/thumbnail_tab_helper.cc (right):

https://codereview.chromium.org/2859263002/diff/20001/chrome/browser/thumbnai...
chrome/browser/thumbnails/thumbnail_tab_helper.cc:35: //    When a renderer is
about to be hidden (this usually occurs when the
Can you mention the new behavior in a separate paragraph here?

[Marc Treib, 2017-05-08 08:30:58]

Thanks!

https://codereview.chromium.org/2859263002/diff/20001/chrome/browser/thumbnai...
File chrome/browser/thumbnails/thumbnail_tab_helper.cc (right):

https://codereview.chromium.org/2859263002/diff/20001/chrome/browser/thumbnai...
chrome/browser/thumbnails/thumbnail_tab_helper.cc:35: //    When a renderer is
about to be hidden (this usually occurs when the
On 2017/05/05 21:32:01, Lei Zhang wrote:
> Can you mention the new behavior in a separate paragraph here?

Done.

[Marc Treib, 2017-05-08 08:35:57]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 08:36:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 09:48:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 09:48:24]

Dry run: This issue passed the CQ dry run.

[Marc Treib, 2017-05-08 09:55:39]

The CQ bit was checked by treib@chromium.org

[Marc Treib, 2017-05-08 09:55:39]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2859263002/#ps40001
(title: "review: comment")

[commit-bot: I haz the power, 2017-05-08 09:56:02]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 10:00:39]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494237339069410,
"parent_rev": "3fc19030bddec86916b383a5c9954b3820693cd8", "commit_rev":
"32d2e42a7df134836e116dcadd1ad70cd489d1c3"}

[commit-bot: I haz the power, 2017-05-08 10:00:48]

Description was changed from

==========
ThumbnailTabHelper: Capture thumbnail when page load finishes

Hidden behind a flag.

BUG=718413
==========

to

==========
ThumbnailTabHelper: Capture thumbnail when page load finishes

Hidden behind a flag.

BUG=718413

Review-Url: https://codereview.chromium.org/2859263002
Cr-Commit-Position: refs/heads/master@{#469943}
Committed:
https://chromium.googlesource.com/chromium/src/+/32d2e42a7df134836e116dcadd1a...
==========

[commit-bot: I haz the power, 2017-05-08 10:00:48]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/32d2e42a7df134836e116dcadd1a...