Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issue 2859263002: ThumbnailTabHelper: Capture thumbnail when page load finishes (Closed)

Created:
3 years, 7 months ago by Marc Treib
Modified:
3 years, 7 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

ThumbnailTabHelper: Capture thumbnail when page load finishes Hidden behind a flag. BUG=718413 Review-Url: https://codereview.chromium.org/2859263002 Cr-Commit-Position: refs/heads/master@{#469943} Committed: https://chromium.googlesource.com/chromium/src/+/32d2e42a7df134836e116dcadd1ad70cd489d1c3

Patch Set 1 #

Patch Set 2 : flag #

Total comments: 2

Patch Set 3 : review: comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -19 lines) Patch
M chrome/browser/about_flags.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/flag_descriptions.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/flag_descriptions.cc View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/thumbnails/thumbnail_tab_helper.h View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/thumbnails/thumbnail_tab_helper.cc View 1 2 10 chunks +20 lines, -19 lines 0 comments Download
M chrome/common/chrome_features.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/chrome_features.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M tools/metrics/histograms/enums.xml View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
Marc Treib
PTAL! [Unfortunately, c/b/thumbnails/ doesn't have any more specific owners, and it seems you reviewed the ...
3 years, 7 months ago (2017-05-05 11:10:23 UTC) #6
Lei Zhang
lgtm Ya, I don't know who would be a good owner here either. https://codereview.chromium.org/2859263002/diff/20001/chrome/browser/thumbnails/thumbnail_tab_helper.cc File ...
3 years, 7 months ago (2017-05-05 21:32:01 UTC) #7
Marc Treib
Thanks! https://codereview.chromium.org/2859263002/diff/20001/chrome/browser/thumbnails/thumbnail_tab_helper.cc File chrome/browser/thumbnails/thumbnail_tab_helper.cc (right): https://codereview.chromium.org/2859263002/diff/20001/chrome/browser/thumbnails/thumbnail_tab_helper.cc#newcode35 chrome/browser/thumbnails/thumbnail_tab_helper.cc:35: // When a renderer is about to be ...
3 years, 7 months ago (2017-05-08 08:30:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2859263002/40001
3 years, 7 months ago (2017-05-08 09:56:02 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 10:00:48 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/32d2e42a7df134836e116dcadd1a...

Powered by Google App Engine
This is Rietveld 408576698